NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commited6329c

committed

Avoid memcpy() with same source and destination in pgstat_recv_replslot.

Same type of issue as in commit53d4f5f and earlier fixes; alsofound by apparently-more-picky-than-the-buildfarm valgrind testing.This one is an oversight in commit9868167. Since that's new inHEAD, no need for a back-patch.

1 parent11072e8 commited6329cCopy full SHA for ed6329c

File tree

1 file changed

-4

lines changed

src/backend/postmaster
- pgstat.c

1 file changed

-4

lines changed

`‎src/backend/postmaster/pgstat.c`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -6916,15 +6916,15 @@ pgstat_recv_replslot(PgStat_MsgReplSlot *msg, int len)`
`6916`	`6916`	`return;`
`6917`	`6917`
`6918`	`6918`	`/* it must be a valid replication slot index */`
`6919`		`-Assert(idx>=0&&idx<max_replication_slots);`
	`6919`	`+Assert(idx<nReplSlotStats);`
`6920`	`6920`
`6921`	`6921`	`if (msg->m_drop)`
`6922`	`6922`	`{`
`6923`	`6923`	`/* Remove the replication slot statistics with the given name */`
`6924`		`-memcpy(&replSlotStats[idx],&replSlotStats[nReplSlotStats-1],`
`6925`		`-sizeof(PgStat_ReplSlotStats));`
	`6924`	`+if (idx<nReplSlotStats-1)`
	`6925`	`+memcpy(&replSlotStats[idx],&replSlotStats[nReplSlotStats-1],`
	`6926`	`+sizeof(PgStat_ReplSlotStats));`
`6926`	`6927`	`nReplSlotStats--;`
`6927`		`-Assert(nReplSlotStats >=0);`
`6928`	`6928`	`}`
`6929`	`6929`	`else`
`6930`	`6930`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commited6329c

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/pgstat.c`

0 commit comments