Commited5109a

committed

Fix error reporting of connect_timeout in libpq for value parsing

The logic was correctly detecting a parsing failure, but the parsingerror did not get reported back to the client properly.Reported-by: Ed MorleyAuthor: Lars KanisReviewed-by: Michael PaquierDiscussion:https://postgr.es/m/a9b4cbd7-4ecb-06b2-ebd7-1739bbff3217@greiz-reinsdorf.deBackpatch-through: 12

1 parent2b0f959 commited5109aCopy full SHA for ed5109a

File tree

-0

lines changed

-0

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1992,7 +1992,11 @@ connectDBComplete(PGconn *conn)`
`1992`	`1992`	`{`
`1993`	`1993`	`if (!parse_int_param(conn->connect_timeout,&timeout,conn,`
`1994`	`1994`	`"connect_timeout"))`
	`1995`	`+{`
	`1996`	`+/* mark the connection as bad to report the parsing failure */`
	`1997`	`+conn->status=CONNECTION_BAD;`
`1995`	`1998`	`return0;`
	`1999`	`+}`
`1996`	`2000`
`1997`	`2001`	`if (timeout>0)`
`1998`	`2002`	`{`

Comments

(0)