Commited1884a

committed

Use the AddFile function consistently in MSVC build scripts

We seem to be using a mix of manually adding to the 'files' hash andcalling the Addfile() method. Let's just consistently use AddFile().Reviewed-by: Dagfinn Ilmari MannsåkerDiscussion:https://postgr.es/m/CAApHDvpo6g5csCTjc_0C7DMvgFPomVb0Rh-AcW5afd=Ya=LRuw@mail.gmail.com

1 parent8709228 commited1884aCopy full SHA for ed1884a

File tree

-5

lines changed

-5

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ sub AddFiles`
`58`	`58`
`59`	`59`	`while (my$f =shift)`
`60`	`60`	`{`
`61`		`-$self->{files}->{$dir ."/" .$f } = 1;`
	`61`	`+$self->AddFile($dir ."/" .$f, 1);`
`62`	`62`	`}`
`63`	`63`	`return;`
`64`	`64`	`}`
`@@ -77,14 +77,14 @@ sub ReplaceFile`
`77`	`77`	`if ($fileeq$filename)`
`78`	`78`	`{`
`79`	`79`	`delete$self->{files}{$file};`
`80`		`-$self->{files}{$newname} = 1;`
	`80`	`+$self->AddFile($newname);`
`81`	`81`	`return;`
`82`	`82`	`}`
`83`	`83`	`}`
`84`	`84`	`elsif ($file =~m/($re)/)`
`85`	`85`	`{`
`86`	`86`	`delete$self->{files}{$file};`
`87`		`-$self->{files}{"$newname/$filename"} = 1;`
	`87`	`+$self->AddFile("$newname/$filename");`
`88`	`88`	`return;`
`89`	`89`	`}`
`90`	`90`	`}`
`@@ -259,11 +259,11 @@ sub AddDir`
`259`	`259`	`if ($f =~/^\$$top_builddir$\/(.*)/)`
`260`	`260`	`{`
`261`	`261`	`$f =$1;`
`262`		`-$self->{files}->{$f} = 1;`
	`262`	`+$self->AddFile($f);`
`263`	`263`	`}`
`264`	`264`	`else`
`265`	`265`	`{`
`266`		`-$self->{files}->{"$reldir/$f"} = 1;`
	`266`	`+$self->AddFile("$reldir/$f");`
`267`	`267`	`}`
`268`	`268`	`}`
`269`	`269`	`$mf =~s{OBJS[^=]=\s(.*)$}{}m;`

Comments

(0)