NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitecb5af7

committed

Remove unused #include's from bin .c files

as determined by IWYUSimilar to commitdbbca2c, but for bin and some related files.Discussion:https://www.postgresql.org/message-id/flat/0df1d5b1-8ca8-4f84-93be-121081bde049%40eisentraut.org

1 parentba08edb commitecb5af7Copy full SHA for ecb5af7

File tree

39 files changed

+10

-57

lines changed

src
- bin
  - pg_basebackup
  - pg_checksums
    - pg_checksums.c
  - pg_combinebackup
    - copy_file.h
    - pg_combinebackup.c
  - pg_config
    - pg_config.c
  - pg_dump
  - pg_rewind
  - pg_test_fsync
    - pg_test_fsync.c
  - pg_upgrade
    - check.c
    - relfilenumber.c
  - pg_walsummary
    - pg_walsummary.c
  - psql
  - scripts
- common
- fe_utils

39 files changed

+10

-57

lines changed

`‎src/bin/pg_basebackup/pg_createsubscriber.c`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,14 +13,13 @@`
`13`	`13`
`14`	`14`	`#include"postgres_fe.h"`
`15`	`15`
	`16`	`+#include<sys/stat.h>`
`16`	`17`	`#include<sys/time.h>`
`17`	`18`	`#include<sys/wait.h>`
`18`	`19`	`#include<time.h>`
`19`	`20`
`20`		`-#include"catalog/pg_authid_d.h"`
`21`	`21`	`#include"common/connect.h"`
`22`	`22`	`#include"common/controldata_utils.h"`
`23`		`-#include"common/file_perm.h"`
`24`	`23`	`#include"common/logging.h"`
`25`	`24`	`#include"common/pg_prng.h"`
`26`	`25`	`#include"common/restricted_token.h"`

`‎src/bin/pg_basebackup/pg_recvlogical.c`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,6 @@`
`18`	`18`	`#include<sys/stat.h>`
`19`	`19`	`#include<unistd.h>`
`20`	`20`
`21`		`-#include"access/xlog_internal.h"`
`22`		`-#include"common/fe_memutils.h"`
`23`	`21`	`#include"common/file_perm.h"`
`24`	`22`	`#include"common/logging.h"`
`25`	`23`	`#include"fe_utils/option_utils.h"`

`‎src/bin/pg_basebackup/receivelog.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@`
`19`	`19`	`#include<unistd.h>`
`20`	`20`
`21`	`21`	`#include"access/xlog_internal.h"`
`22`		`-#include"common/file_utils.h"`
`23`	`22`	`#include"common/logging.h"`
`24`	`23`	`#include"libpq-fe.h"`
`25`	`24`	`#include"receivelog.h"`

`‎src/bin/pg_basebackup/streamutil.c`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,14 +19,12 @@`
`19`	`19`
`20`	`20`	`#include"access/xlog_internal.h"`
`21`	`21`	`#include"common/connect.h"`
`22`		`-#include"common/fe_memutils.h"`
`23`	`22`	`#include"common/file_perm.h"`
`24`	`23`	`#include"common/logging.h"`
`25`	`24`	`#include"common/string.h"`
`26`	`25`	`#include"datatype/timestamp.h"`
`27`	`26`	`#include"port/pg_bswap.h"`
`28`	`27`	`#include"pqexpbuffer.h"`
`29`		`-#include"receivelog.h"`
`30`	`28`	`#include"streamutil.h"`
`31`	`29`
`32`	`30`	`#defineERRCODE_DUPLICATE_OBJECT "42710"`

`‎src/bin/pg_basebackup/walmethods.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`
`12`	`12`	`#include"postgres_fe.h"`
`13`	`13`
	`14`	`+#include<fcntl.h>`
`14`	`15`	`#include<sys/stat.h>`
`15`	`16`	`#include<time.h>`
`16`	`17`	`#include<unistd.h>`
`@@ -26,8 +27,7 @@`
`26`	`27`	`#include"common/file_utils.h"`
`27`	`28`	`#include"common/logging.h"`
`28`	`29`	`#include"pgtar.h"`
`29`		`-#include"receivelog.h"`
`30`		`-#include"streamutil.h"`
	`30`	`+#include"walmethods.h"`
`31`	`31`
`32`	`32`	`/* Size of zlib buffer for .tar.gz */`
`33`	`33`	`#defineZLIB_OUT_SIZE 4096`

`‎src/bin/pg_checksums/pg_checksums.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@`
`21`	`21`	`#include<unistd.h>`
`22`	`22`
`23`	`23`	`#include"common/controldata_utils.h"`
`24`		`-#include"common/file_perm.h"`
`25`	`24`	`#include"common/file_utils.h"`
`26`	`25`	`#include"common/logging.h"`
`27`	`26`	`#include"common/relpath.h"`

`‎src/bin/pg_combinebackup/copy_file.h`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,6 @@`
`13`	`13`
`14`	`14`	`#include"c.h"`
`15`	`15`	`#include"common/checksum_helper.h"`
`16`		`-#include"common/file_utils.h"`
`17`	`16`
`18`	`17`	`/*`
`19`	`18`	`* Enumeration to denote copy modes.`

`‎src/bin/pg_combinebackup/pg_combinebackup.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -25,12 +25,12 @@`
`25`	`25`	`#endif`
`26`	`26`
`27`	`27`	`#include"backup_label.h"`
`28`		`-#include"common/blkreftable.h"`
`29`	`28`	`#include"common/checksum_helper.h"`
`30`	`29`	`#include"common/controldata_utils.h"`
`31`	`30`	`#include"common/file_perm.h"`
`32`	`31`	`#include"common/file_utils.h"`
`33`	`32`	`#include"common/logging.h"`
	`33`	`+#include"common/relpath.h"`
`34`	`34`	`#include"copy_file.h"`
`35`	`35`	`#include"fe_utils/option_utils.h"`
`36`	`36`	`#include"getopt_long.h"`

`‎src/bin/pg_config/pg_config.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@`
`25`	`25`	`#include"postgres_fe.h"`
`26`	`26`
`27`	`27`	`#include"common/config_info.h"`
`28`		`-#include"port.h"`
`29`	`28`
`30`	`29`	`staticconstchar*progname;`
`31`	`30`

`‎src/bin/pg_dump/common.c`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,6 @@`
`27`	`27`	`#include"catalog/pg_subscription_d.h"`
`28`	`28`	`#include"catalog/pg_type_d.h"`
`29`	`29`	`#include"common/hashfn.h"`
`30`		`-#include"fe_utils/string_utils.h"`
`31`		`-#include"pg_backup_archiver.h"`
`32`	`30`	`#include"pg_backup_utils.h"`
`33`	`31`	`#include"pg_dump.h"`
`34`	`32`

`‎src/bin/pg_dump/compress_io.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,6 @@`
`70`	`70`	`#include"compress_lz4.h"`
`71`	`71`	`#include"compress_none.h"`
`72`	`72`	`#include"compress_zstd.h"`
`73`		`-#include"pg_backup_utils.h"`
`74`	`73`
`75`	`74`	`/*----------------------`
`76`	`75`	`* Generic functions`

`‎src/bin/pg_dump/filter.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,6 @@`
`13`	`13`	`*/`
`14`	`14`	`#include"postgres_fe.h"`
`15`	`15`
`16`		`-#include"common/fe_memutils.h"`
`17`	`16`	`#include"common/logging.h"`
`18`	`17`	`#include"common/string.h"`
`19`	`18`	`#include"filter.h"`

`‎src/bin/pg_dump/parallel.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,9 @@`
`63`	`63`	`#include"fe_utils/string_utils.h"`
`64`	`64`	`#include"parallel.h"`
`65`	`65`	`#include"pg_backup_utils.h"`
	`66`	`+#ifdefWIN32`
`66`	`67`	`#include"port/pg_bswap.h"`
	`68`	`+#endif`
`67`	`69`
`68`	`70`	`/* Mnemonic macros for indexing the fd array returned by pipe(2) */`
`69`	`71`	`#definePIPE_READ0`

`‎src/bin/pg_dump/pg_backup_custom.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@`
`27`	`27`
`28`	`28`	`#include"common/file_utils.h"`
`29`	`29`	`#include"compress_io.h"`
`30`		`-#include"parallel.h"`
`31`	`30`	`#include"pg_backup_utils.h"`
`32`	`31`
`33`	`32`	`/*--------`

`‎src/bin/pg_dump/pg_backup_db.c`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,6 @@`
`19`	`19`
`20`	`20`	`#include"common/connect.h"`
`21`	`21`	`#include"common/string.h"`
`22`		`-#include"dumputils.h"`
`23`		`-#include"fe_utils/string_utils.h"`
`24`	`22`	`#include"parallel.h"`
`25`	`23`	`#include"pg_backup_archiver.h"`
`26`	`24`	`#include"pg_backup_db.h"`

`‎src/bin/pg_dump/pg_backup_utils.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,9 @@`
`13`	`13`	`*/`
`14`	`14`	`#include"postgres_fe.h"`
`15`	`15`
	`16`	`+#ifdefWIN32`
`16`	`17`	`#include"parallel.h"`
	`18`	`+#endif`
`17`	`19`	`#include"pg_backup_utils.h"`
`18`	`20`
`19`	`21`	`/* Globals exported by this file */`

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -49,10 +49,8 @@`
`49`	`49`	`#include "catalog/pg_class_d.h"`
`50`	`50`	`#include "catalog/pg_default_acl_d.h"`
`51`	`51`	`#include "catalog/pg_largeobject_d.h"`
`52`		`-#include "catalog/pg_largeobject_metadata_d.h"`
`53`	`52`	`#include "catalog/pg_proc_d.h"`
`54`	`53`	`#include "catalog/pg_subscription.h"`
`55`		`-#include "catalog/pg_trigger_d.h"`
`56`	`54`	`#include "catalog/pg_type_d.h"`
`57`	`55`	`#include "common/connect.h"`
`58`	`56`	`#include "common/int.h"`

`‎src/bin/pg_dump/pg_dump_sort.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`#include"catalog/pg_class_d.h"`
`19`	`19`	`#include"common/int.h"`
`20`	`20`	`#include"lib/binaryheap.h"`
`21`		`-#include"pg_backup_archiver.h"`
`22`	`21`	`#include"pg_backup_utils.h"`
`23`	`22`	`#include"pg_dump.h"`
`24`	`23`

`‎src/bin/pg_dump/pg_restore.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,6 @@`
`45`	`45`	`#include<termios.h>`
`46`	`46`	`#endif`
`47`	`47`
`48`		`-#include"dumputils.h"`
`49`	`48`	`#include"fe_utils/option_utils.h"`
`50`	`49`	`#include"filter.h"`
`51`	`50`	`#include"getopt_long.h"`

`‎src/bin/pg_rewind/datapagemap.h`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@`
`10`	`10`	`#defineDATAPAGEMAP_H`
`11`	`11`
`12`	`12`	`#include"storage/block.h"`
`13`		`-#include"storage/relfilelocator.h"`
`14`	`13`
`15`	`14`	`structdatapagemap`
`16`	`15`	`{`

`‎src/bin/pg_rewind/libpq_source.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@`
`11`	`11`
`12`	`12`	`#include"catalog/pg_type_d.h"`
`13`	`13`	`#include"common/connect.h"`
`14`		`-#include"datapagemap.h"`
`15`	`14`	`#include"file_ops.h"`
`16`	`15`	`#include"filemap.h"`
`17`	`16`	`#include"lib/stringinfo.h"`

`‎src/bin/pg_rewind/local_source.c`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,10 +12,8 @@`
`12`	`12`	`#include<fcntl.h>`
`13`	`13`	`#include<unistd.h>`
`14`	`14`
`15`		`-#include"datapagemap.h"`
	`15`	`+#include"common/logging.h"`
`16`	`16`	`#include"file_ops.h"`
`17`		`-#include"filemap.h"`
`18`		`-#include"pg_rewind.h"`
`19`	`17`	`#include"rewind_source.h"`
`20`	`18`
`21`	`19`	`typedefstruct`

`‎src/bin/pg_rewind/pg_rewind.h`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,10 +14,6 @@`
`14`	`14`	`#include"access/timeline.h"`
`15`	`15`	`#include"common/logging.h"`
`16`	`16`	`#include"common/file_utils.h"`
`17`		`-#include"datapagemap.h"`
`18`		`-#include"libpq-fe.h"`
`19`		`-#include"storage/block.h"`
`20`		`-#include"storage/relfilelocator.h"`
`21`	`17`
`22`	`18`	`/* Configuration options */`
`23`	`19`	`externchar*datadir_target;`

`‎src/bin/pg_test_fsync/pg_test_fsync.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@`
`19`	`19`	`#include<unistd.h>`
`20`	`20`	`#include<signal.h>`
`21`	`21`
`22`		`-#include"access/xlogdefs.h"`
`23`	`22`	`#include"common/logging.h"`
`24`	`23`	`#include"common/pg_prng.h"`
`25`	`24`	`#include"getopt_long.h"`

`‎src/bin/pg_upgrade/check.c`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,7 @@`
`11`	`11`
`12`	`12`	`#include"catalog/pg_authid_d.h"`
`13`	`13`	`#include"catalog/pg_class_d.h"`
`14`		`-#include"catalog/pg_collation.h"`
`15`	`14`	`#include"fe_utils/string_utils.h"`
`16`		`-#include"mb/pg_wchar.h"`
`17`	`15`	`#include"pg_upgrade.h"`
`18`	`16`
`19`	`17`	`staticvoidcheck_new_cluster_is_empty(void);`

`‎src/bin/pg_upgrade/relfilenumber.c`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,6 @@`
`11`	`11`
`12`	`12`	`#include<sys/stat.h>`
`13`	`13`
`14`		`-#include"access/transam.h"`
`15`		`-#include"catalog/pg_class_d.h"`
`16`	`14`	`#include"pg_upgrade.h"`
`17`	`15`
`18`	`16`	`staticvoidtransfer_single_new_db(FileNameMapmaps,intsize,charold_tablespace);`

`‎src/bin/pg_walsummary/pg_walsummary.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@`
`20`	`20`	`#include"common/logging.h"`
`21`	`21`	`#include"fe_utils/option_utils.h"`
`22`	`22`	`#include"getopt_long.h"`
`23`		`-#include"lib/stringinfo.h"`
`24`	`23`
`25`	`24`	`typedefstructws_options`
`26`	`25`	`{`

`‎src/bin/psql/command.c`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,18 +30,15 @@`
`30`	`30`	`#include"common/logging.h"`
`31`	`31`	`#include"common/string.h"`
`32`	`32`	`#include"copy.h"`
`33`		`-#include"crosstabview.h"`
`34`	`33`	`#include"describe.h"`
`35`	`34`	`#include"fe_utils/cancel.h"`
`36`	`35`	`#include"fe_utils/print.h"`
`37`	`36`	`#include"fe_utils/string_utils.h"`
`38`	`37`	`#include"help.h"`
`39`	`38`	`#include"input.h"`
`40`	`39`	`#include"large_obj.h"`
`41`		`-#include"libpq-fe.h"`
`42`	`40`	`#include"libpq/pqcomm.h"`
`43`	`41`	`#include"mainloop.h"`
`44`		`-#include"portability/instr_time.h"`
`45`	`42`	`#include"pqexpbuffer.h"`
`46`	`43`	`#include"psqlscanslash.h"`
`47`	`44`	`#include"settings.h"`

`‎src/bin/psql/describe.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@`
`27`	`27`	`#include"fe_utils/print.h"`
`28`	`28`	`#include"fe_utils/string_utils.h"`
`29`	`29`	`#include"settings.h"`
`30`		`-#include"variables.h"`
`31`	`30`
`32`	`31`	`staticconstcharmap_typename_pattern(constcharpattern);`
`33`	`32`	`staticbooldescribeOneTableDetails(constchar*schemaname,`

`‎src/bin/psql/help.c`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,6 @@`
`21`	`21`	`#include<termios.h>`
`22`	`22`	`#endif`
`23`	`23`
`24`		`-#include"common.h"`
`25`		`-#include"common/logging.h"`
`26`		`-#include"common/username.h"`
`27`	`24`	`#include"help.h"`
`28`	`25`	`#include"input.h"`
`29`	`26`	`#include"settings.h"`

`‎src/bin/scripts/clusterdb.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@`
`16`	`16`	`#include"fe_utils/option_utils.h"`
`17`	`17`	`#include"fe_utils/query_utils.h"`
`18`	`18`	`#include"fe_utils/simple_list.h"`
`19`		`-#include"fe_utils/string_utils.h"`
`20`	`19`
`21`	`20`
`22`	`21`	`staticvoidcluster_one_database(constConnParamscparams,constchartable,`

`‎src/bin/scripts/common.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@`
`21`	`21`	`#include"common/connect.h"`
`22`	`22`	`#include"common/logging.h"`
`23`	`23`	`#include"common/string.h"`
`24`		`-#include"fe_utils/cancel.h"`
`25`	`24`	`#include"fe_utils/query_utils.h"`
`26`	`25`	`#include"fe_utils/string_utils.h"`
`27`	`26`

`‎src/bin/scripts/reindexdb.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`
`16`	`16`	`#include"catalog/pg_class_d.h"`
`17`	`17`	`#include"common.h"`
`18`		`-#include"common/connect.h"`
`19`	`18`	`#include"common/logging.h"`
`20`	`19`	`#include"fe_utils/cancel.h"`
`21`	`20`	`#include"fe_utils/option_utils.h"`

`‎src/common/controldata_utils.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,8 @@`
`28`	`28`	`#include"access/xlog_internal.h"`
`29`	`29`	`#include"catalog/pg_control.h"`
`30`	`30`	`#include"common/controldata_utils.h"`
`31`		`-#include"common/file_perm.h"`
`32`	`31`	`#ifdefFRONTEND`
	`32`	`+#include"common/file_perm.h"`
`33`	`33`	`#include"common/logging.h"`
`34`	`34`	`#endif`
`35`	`35`	`#include"port/pg_crc32c.h"`

`‎src/common/string.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@`
`22`	`22`	`#endif`
`23`	`23`
`24`	`24`	`#include"common/string.h"`
`25`		`-#include"lib/stringinfo.h"`
`26`	`25`
`27`	`26`
`28`	`27`	`/*`

`‎src/common/unicode_case.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`
`18`	`18`	`#include"common/unicode_case.h"`
`19`	`19`	`#include"common/unicode_case_table.h"`
`20`		`-#include"common/unicode_category.h"`
`21`	`20`	`#include"mb/pg_wchar.h"`
`22`	`21`
`23`	`22`	`staticconstpg_case_map*find_case_map(pg_wcharucs);`

`‎src/fe_utils/astreamer_file.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@`
`19`	`19`
`20`	`20`	`#include"common/file_perm.h"`
`21`	`21`	`#include"common/logging.h"`
`22`		`-#include"common/string.h"`
`23`	`22`	`#include"fe_utils/astreamer.h"`
`24`	`23`
`25`	`24`	`typedefstructastreamer_plain_writer`

`‎src/fe_utils/astreamer_gzip.c`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,7 @@`
`32`	`32`	`#include<zlib.h>`
`33`	`33`	`#endif`
`34`	`34`
`35`		`-#include"common/file_perm.h"`
`36`	`35`	`#include"common/logging.h"`
`37`		`-#include"common/string.h"`
`38`	`36`	`#include"fe_utils/astreamer.h"`
`39`	`37`
`40`	`38`	`#ifdefHAVE_LIBZ`

`‎src/fe_utils/astreamer_lz4.c`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,7 @@`
`21`	`21`	`#include<lz4frame.h>`
`22`	`22`	`#endif`
`23`	`23`
`24`		`-#include"common/file_perm.h"`
`25`	`24`	`#include"common/logging.h"`
`26`		`-#include"common/string.h"`
`27`	`25`	`#include"fe_utils/astreamer.h"`
`28`	`26`
`29`	`27`	`#ifdefUSE_LZ4`

0 commit comments

Comments

(0)

Movatterモバイル変換

File tree

39 files changed

39 files changed

0 commit comments