NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitec67869

committed

Make write of pgstats file durable at shutdown

This switches the pgstats write code to use durable_rename() rather thanrename(). This ensures that the stats file's data is durable when thestatistics are written, which is something only happening at shutdownnow with the checkpointer doing the job.This could cause the statistics to be lost even after PostgreSQL is shutdown, should a host failure happen, for example.Suggested-by: Konstantin KnizhnikReviewed-by: Bertrand DrouvotDiscussion:https://postgr.es/m/ZpDQTZ0cAz0WEbh7@paquier.xyz

1 parent4b74ebf commitec67869Copy full SHA for ec67869

File tree

1 file changed

-5

lines changed

src/backend/utils/activity
- pgstat.c

1 file changed

-5

lines changed

`‎src/backend/utils/activity/pgstat.c`

Lines changed: 2 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1478,12 +1478,9 @@ pgstat_write_statsfile(void)`
`1478`	`1478`	`tmpfile)));`
`1479`	`1479`	`unlink(tmpfile);`
`1480`	`1480`	`}`
`1481`		`-elseif (rename(tmpfile,statfile)<0)`
	`1481`	`+elseif (durable_rename(tmpfile,statfile,LOG)<0)`
`1482`	`1482`	`{`
`1483`		`-ereport(LOG,`
`1484`		`-(errcode_for_file_access(),`
`1485`		`-errmsg("could not rename temporary statistics file \"%s\" to \"%s\": %m",`
`1486`		`-tmpfile,statfile)));`
	`1483`	`+/* durable_rename already emitted log message */`
`1487`	`1484`	`unlink(tmpfile);`
`1488`	`1485`	`}`
`1489`	`1486`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitec67869

File tree

1 file changed

1 file changed

`‎src/backend/utils/activity/pgstat.c`

0 commit comments