NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitec5a010

committed

Fix pfree issue in presorted DISTINCT aggregate code

The logic in this area was recently changed in7da5159, however, in thatcommit, I neglected to consider that the conditions in which we shouldpfree the old Datum needed to be updated after that change. This couldresult in trying to pfree a NULL value, as was demonstrated by AlexanderLakhin.Reported-by: Alexander LakhinDiscussion:https://postgr.es/m/4103db46-d888-6d1d-e88d-87c21ed99472@gmail.com

1 parentbd94488 commitec5a010Copy full SHA for ec5a010

File tree

1 file changed

-1

lines changed

src/backend/executor
- execExprInterp.c

1 file changed

-1

lines changed

`‎src/backend/executor/execExprInterp.c‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4254,7 +4254,8 @@ ExecEvalPreOrderedDistinctSingle(AggState *aggstate, AggStatePerTrans pertrans)`
`4254`	`4254`	`pertrans->aggCollation,`
`4255`	`4255`	`pertrans->lastdatum,value))))`
`4256`	`4256`	`{`
`4257`		`-if (pertrans->haslast&& !pertrans->inputtypeByVal)`
	`4257`	`+if (pertrans->haslast&& !pertrans->inputtypeByVal&&`
	`4258`	`+!pertrans->lastisnull)`
`4258`	`4259`	`pfree(DatumGetPointer(pertrans->lastdatum));`
`4259`	`4260`
`4260`	`4261`	`pertrans->haslast= true;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitec5a010

File tree

1 file changed

1 file changed

`‎src/backend/executor/execExprInterp.c‎`

0 commit comments