Commiteb6e9b5

committed

Properly set relpersistence for fake relcache entries.

This can result in buffers failing to be properly flushed atcheckpoint time, leading to data loss.Report, diagnosis, and patch by Jeff Davis.

1 parent269dbaf commiteb6e9b5Copy full SHA for eb6e9b5

File tree

-0

lines changed

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -394,6 +394,8 @@ CreateFakeRelcacheEntry(RelFileNode rnode)`
`394`	`394`	`FakeRelCacheEntryfakeentry;`
`395`	`395`	`Relationrel;`
`396`	`396`
	`397`	`+Assert(InRecovery);`
	`398`	`+`
`397`	`399`	`/* Allocate the Relation struct and all related space in one block. */`
`398`	`400`	`fakeentry=palloc0(sizeof(FakeRelCacheEntryData));`
`399`	`401`	`rel= (Relation)fakeentry;`
`@@ -403,6 +405,9 @@ CreateFakeRelcacheEntry(RelFileNode rnode)`
`403`	`405`	`/* We will never be working with temp rels during recovery */`
`404`	`406`	`rel->rd_backend=InvalidBackendId;`
`405`	`407`
	`408`	`+/* It must be a permanent table if we're in recovery. */`
	`409`	`+rel->rd_rel->relpersistence=RELPERSISTENCE_PERMANENT;`
	`410`	`+`
`406`	`411`	`/* We don't know the name of the relation; use relfilenode instead */`
`407`	`412`	`sprintf(RelationGetRelationName(rel),"%u",rnode.relNode);`
`408`	`413`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -271,6 +271,8 @@ ReadBufferWithoutRelcache(RelFileNode rnode, ForkNumber forkNum,`
`271`	`271`
`272`	`272`	`SMgrRelationsmgr=smgropen(rnode,InvalidBackendId);`
`273`	`273`
	`274`	`+Assert(InRecovery);`
	`275`	`+`
`274`	`276`	`returnReadBuffer_common(smgr,RELPERSISTENCE_PERMANENT,forkNum,blockNum,`
`275`	`277`	`mode,strategy,&hit);`
`276`	`278`	`}`

Comments

(0)