Movatterモバイル変換

Skip to content

postgrespro/postgresPublic

forked frompostgres/postgres

NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commiteb43f3d

michaelpq

committed

Fix inconsistencies and typos in the tree

This is numbered take 8, and addresses again a set of issues with codecomments, variable names and unreferenced variables.Author: Alexander LakhinDiscussion:https://postgr.es/m/b137b5eb-9c95-9c2f-586e-38aba7d59788@gmail.com

1 parent7cce159 commiteb43f3dCopy full SHA for eb43f3d

File tree

42 files changed

+58

-75

lines changed

contrib/pgcrypto
- pgp-decrypt.c
doc/src/sgml
src
- Makefile.global.in
- backend
  - access
    - common
      - bufmask.c
    - gin
      - gindatapage.c
    - heap
      - rewriteheap.c
    - spgist
      - spgvacuum.c
    - transam
      - xact.c
      - xlog.c
  - catalog
    - pg_aggregate.c
  - commands
    - dbcommands.c
    - operatorcmds.c
  - libpq
    - auth.c
  - postmaster
    - bgwriter.c
  - replication
    - walsender.c
  - storage
    - ipc
      - procarray.c
      - standby.c
    - lmgr
      - lwlock.c
    - smgr
      - md.c
  - tcop
    - pquery.c
  - utils
    - adt
      - arrayfuncs.c
      - like_match.c
    - mmgr
      - aset.c
- bin
  - initdb
    - initdb.c
  - pg_controldata
    - pg_controldata.c
  - pg_ctl
    - pg_ctl.c
  - pg_upgrade
    - pg_upgrade.h
  - pgevent
    - README
- common
  - unicode_norm.c
- include
  - access
    - gist_private.h
  - commands
    - dbcommands.h
  - replication
    - logicalproto.h
  - statistics
    - statistics.h
  - storage
- interfaces/libpq
  - fe-exec.c
- pl/plperl
  - plperl.c
- tools
  - FAQ2txt

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+58

-75

lines changed

`‎contrib/pgcrypto/pgp-decrypt.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -355,7 +355,7 @@ mdc_finish(PGP_Context ctx, PullFilter src, int len)`
`355`	`355`	`if (len!=20)`
`356`	`356`	`returnPXE_PGP_CORRUPT_DATA;`
`357`	`357`
`358`		`-/* mdc_read should not callmd_update */`
	`358`	`+/* mdc_read should not callpx_md_update */`
`359`	`359`	`ctx->in_mdc_pkt=1;`
`360`	`360`
`361`	`361`	`/* read data */`

`‎doc/src/sgml/custom-scan.sgml‎`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -83,10 +83,7 @@ typedef struct CustomPath`
`83`	`83`	`by <literal>nodeToString</literal>, so that debugging routines that attempt to`
`84`	`84`	`print the custom path will work as designed. <structfield>methods</structfield> must`
`85`	`85`	`point to a (usually statically allocated) object implementing the required`
`86`		`- custom path methods, of which there is currently only one. The`
`87`		`- <structfield>LibraryName</structfield> and <structfield>SymbolName</structfield> fields must also`
`88`		`- be initialized so that the dynamic loader can resolve them to locate the`
`89`		`- method table.`
	`86`	`+ custom path methods, of which there is currently only one.`
`90`	`87`	`</para>`
`91`	`88`
`92`	`89`	`<para>`

`‎doc/src/sgml/ref/create_aggregate.sgml‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ CREATE [ OR REPLACE ] AGGREGATE <replaceable class="parameter">name</replaceable`
`211`	`211`	`as described in <xref linkend="xaggr-moving-aggregates"/>. This requires`
`212`	`212`	`specifying the <literal>MSFUNC</literal>, <literal>MINVFUNC</literal>,`
`213`	`213`	`and <literal>MSTYPE</literal> parameters, and optionally`
`214`		`- the <literal>MSPACE</literal>, <literal>MFINALFUNC</literal>,`
	`214`	`+ the <literal>MSSPACE</literal>, <literal>MFINALFUNC</literal>,`
`215`	`215`	`<literal>MFINALFUNC_EXTRA</literal>, <literal>MFINALFUNC_MODIFY</literal>,`
`216`	`216`	`and <literal>MINITCOND</literal> parameters. Except for <literal>MINVFUNC</literal>,`
`217`	`217`	`these parameters work like the corresponding simple-aggregate parameters`

`‎doc/src/sgml/xplang.sgml‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ CREATE FUNCTION <replaceable>validator_function_name</replaceable>(oid)`
`137`	`137`	`<para>`
`138`	`138`	`Finally, the PL must be declared with the command`
`139`	`139`	`<synopsis>`
`140`		`-CREATE <optional>TRUSTED</optional> LANGUAGE <replaceable>language-name</replaceable>`
	`140`	`+CREATE <optional>TRUSTED</optional> LANGUAGE <replaceable>language_name</replaceable>`
`141`	`141`	`HANDLER <replaceable>handler_function_name</replaceable>`
`142`	`142`	`<optional>INLINE <replaceable>inline_function_name</replaceable></optional>`
`143`	`143`	`<optional>VALIDATOR <replaceable>validator_function_name</replaceable></optional> ;`

`‎src/Makefile.global.in‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ standard_targets = all install installdirs uninstall distprep clean distclean ma`
`23`	`23`	`# these targets should recurse even into subdirectories not being built:`
`24`	`24`	`standard_always_targets = distprep clean distclean maintainer-clean`
`25`	`25`
`26`		`-.PHONY:$(standard_targets) install-strip html man installcheck-parallel maintainer-check`
	`26`	`+.PHONY:$(standard_targets) install-strip html man installcheck-parallel`
`27`	`27`
`28`	`28`	# make `all' the default target
`29`	`29`	`all:`

`‎src/backend/access/common/bufmask.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`#include"access/bufmask.h"`
`21`	`21`
`22`	`22`	`/*`
`23`		`- *mask_page_lsn`
	`23`	`+ *mask_page_lsn_and_checksum`
`24`	`24`	`*`
`25`	`25`	`* In consistency checks, the LSN of the two pages compared will likely be`
`26`	`26`	`* different because of concurrent operations when the WAL is generated and`

`‎src/backend/access/gin/gindatapage.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1371,7 +1371,7 @@ disassembleLeaf(Page page)`
`1371`	`1371`	`if (GinPageIsCompressed(page))`
`1372`	`1372`	`{`
`1373`	`1373`	`/*`
`1374`		`- * Create aleafSegment entry for each segment.`
	`1374`	`+ * Create aleafSegmentInfo entry for each segment.`
`1375`	`1375`	`*/`
`1376`	`1376`	`seg=GinDataLeafPageGetPostingList(page);`
`1377`	`1377`	`segbegin= (Pointer)seg;`

`‎src/backend/access/heap/rewriteheap.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ static void logical_end_heap_rewrite(RewriteState state);`
`237`	`237`	`* new_heapnew, locked heap relation to insert tuples to`
`238`	`238`	`* oldest_xminxid used by the caller to determine which tuples are dead`
`239`	`239`	`* freeze_xidxid before which tuples will be frozen`
`240`		`- *min_multimultixact before which multis will be removed`
	`240`	`+ *cutoff_multimultixact before which multis will be removed`
`241`	`241`	`* use_walshould the inserts to the new heap be WAL-logged?`
`242`	`242`	`*`
`243`	`243`	`* Returns an opaque RewriteState, allocated in current memory context,`
`@@ -787,7 +787,7 @@ raw_heap_insert(RewriteState state, HeapTuple tup)`
`787`	`787`	`* Instead we simply write the mapping files out to disk, before the`
`788`	`788`	`* XLogInsert() is performed. That guarantees that either the XLogInsert() is`
`789`	`789`	`* inserted after the checkpoint's redo pointer or that the checkpoint (via`
`790`		`- *LogicalRewriteHeapCheckpoint()) has flushed the (partial) mapping file to`
	`790`	`+ *CheckPointLogicalRewriteHeap()) has flushed the (partial) mapping file to`
`791`	`791`	`* disk. That leaves the tail end that has not yet been flushed open to`
`792`	`792`	`* corruption, which is solved by including the current offset in the`
`793`	`793`	`* xl_heap_rewrite_mapping records and truncating the mapping file to it`

`‎src/backend/access/spgist/spgvacuum.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -842,7 +842,7 @@ spgvacuumscan(spgBulkDeleteState *bds)`
`842`	`842`	`}`
`843`	`843`	`}`
`844`	`844`
`845`		`-/* Propagate locallastUsedPage cache to metablock */`
	`845`	`+/* Propagate locallastUsedPages cache to metablock */`
`846`	`846`	`SpGistUpdateMetaPage(index);`
`847`	`847`
`848`	`848`	`/*`

`‎src/backend/access/transam/xact.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1988,7 +1988,7 @@ StartTransaction(void)`
`1988`	`1988`
`1989`	`1989`	`/*`
`1990`	`1990`	`* Advertise it in the proc array. We assume assignment of`
`1991`		`- *LocalTransactionID is atomic, and the backendId should be set already.`
	`1991`	`+ *localTransactionId is atomic, and the backendId should be set already.`
`1992`	`1992`	`*/`
`1993`	`1993`	`Assert(MyProc->backendId==vxid.backendId);`
`1994`	`1994`	`MyProc->lxid=vxid.localTransactionId;`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp