NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commiteac0a6c

committed

Avoid locale-dependent output in select_views regression test.

Use 'COLLATE "C"' to force locale-independent sorting of the iexitview results in select_views.sql. We aren't particularly interestedin the exact sorting behavior here, and this doesn't change the shapeof the generated plan, so it seems like a wash as far as the goalsof this test go.This is in response to bug #14637 from Tomasz Kontusz. It doesn'tfully resolve his problem, because he also saw some diffs in thecreate_index test. But other people have had issues with select_viewstoo, and this fix lets us drop the select_views_1.out variant expectedfile altogether, which is a nice win from a maintenance standpoint.Emre HasegeliDiscussion:https://postgr.es/m/20170501000609.24360.24248@wrigleys.postgresql.org

1 parent764cb2b commiteac0a6cCopy full SHA for eac0a6c

File tree

3 files changed

-1554

lines changed

src/test/regress
- expected
  - select_views.out
  - select_views_1.out
- sql
  - select_views.sql

3 files changed

-1554

lines changed

`‎src/test/regress/expected/select_views.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,7 @@ SELECT * FROM street;`
`340`	`340`	`98th Ave \| [(-122.2001,37.258),(-122.1974,37.27)] \| Lafayette`
`341`	`341`	`(333 rows)`
`342`	`342`
`343`		`-SELECT name, #thepath FROM iexit ORDER BY1, 2;`
	`343`	`+SELECT name, #thepath FROM iexit ORDER BYname COLLATE "C", 2;`
`344`	`344`	`name \| ?column?`
`345`	`345`	`------------------------------------+----------`
`346`	`346`	`I- 580 \| 2`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commiteac0a6c

File tree

3 files changed

3 files changed

`‎src/test/regress/expected/select_views.out`

0 commit comments