NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commiteabf98e

committed

simplehash: Free collisions array in SH_STAT

While SH_STAT() is only used for debugging, the allocated array can be large,and therefore should be freed.It's unclear why coverity started warning now.Reported-by: Tom Lane <tgl@sss.pgh.pa.us>Reported-by: CoverityDiscussion:https://postgr.es/m/3005248.1712538233@sss.pgh.pa.usBackpatch: 12-

1 parent5fe7bcc commiteabf98eCopy full SHA for eabf98e

File tree

1 file changed

-0

lines changed

src/include/lib
- simplehash.h

1 file changed

-0

lines changed

`‎src/include/lib/simplehash.h‎`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -977,6 +977,9 @@ SH_STAT(SH_TYPE * tb)`
`977`	`977`	`max_collisions=curcoll;`
`978`	`978`	`}`
`979`	`979`
	`980`	`+/* large enough to be worth freeing, even if just used for debugging */`
	`981`	`+pfree(collisions);`
	`982`	`+`
`980`	`983`	`if (tb->members>0)`
`981`	`984`	`{`
`982`	`985`	`fillfactor=tb->members / ((double)tb->size);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commiteabf98e

File tree

1 file changed

1 file changed

`‎src/include/lib/simplehash.h‎`

0 commit comments