NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commiteaa1dd1

committed

Use PG_TEST_TIMEOUT_DEFAULT in 019_replslot_limit.pl.

Oversight inf2698ea, which introducedthe variable. This lowers some 1000s timeouts to the configurabledefault of 180s, due to a lack of evidence for needing the longertimeout. The alternative was 6*PG_TEST_TIMEOUT_DEFAULT, which we canadopt if the need arises. Given the lack of observed trouble with thesetimeouts, no back-patch.

1 parent61b313e commiteaa1dd1Copy full SHA for eaa1dd1

File tree

1 file changed

-5

lines changed

src/test/recovery/t
- 019_replslot_limit.pl

1 file changed

-5

lines changed

`‎src/test/recovery/t/019_replslot_limit.pl`

Lines changed: 4 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@`
`182`	`182`	`'ALTER SYSTEM RESET max_wal_size; SELECT pg_reload_conf()');`
`183`	`183`	`$node_primary->safe_psql('postgres',"CHECKPOINT;");`
`184`	`184`	`my$invalidated = 0;`
`185`		`-for (my$i = 0;$i <10000;$i++)`
	`185`	`+for (my$i = 0;$i <10 *$PostgreSQL::Test::Utils::timeout_default;$i++)`
`186`	`186`	`{`
`187`	`187`	`if (find_in_log(`
`188`	`188`	`$node_primary,'invalidating obsolete replication slot "rep1"',`
`@@ -205,7 +205,7 @@`
`205`	`205`
`206`	`206`	`# Wait until current checkpoint ends`
`207`	`207`	`my$checkpoint_ended = 0;`
`208`		`-for (my$i = 0;$i <10000;$i++)`
	`208`	`+for (my$i = 0;$i <10 *$PostgreSQL::Test::Utils::timeout_default;$i++)`
`209`	`209`	`{`
`210`	`210`	`if (find_in_log($node_primary,"checkpoint complete:",$logstart))`
`211`	`211`	`{`
`@@ -235,7 +235,7 @@`
`235`	`235`	`$node_standby->start;`
`236`	`236`
`237`	`237`	`my$failed = 0;`
`238`		`-for (my$i = 0;$i <10000;$i++)`
	`238`	`+for (my$i = 0;$i <10 *$PostgreSQL::Test::Utils::timeout_default;$i++)`
`239`	`239`	`{`
`240`	`240`	`if (find_in_log(`
`241`	`241`	`$node_standby,`
`@@ -353,8 +353,7 @@`
`353`	`353`	`stderr=> \$stderr);`
`354`	`354`	`diag$stdout,$stderr;`
`355`	`355`
`356`		`-# unlikely that the problem would resolve after 15s, so give up at point`
`357`		`-if ($i++ == 150)`
	`356`	`+if ($i++ == 10 *$PostgreSQL::Test::Utils::timeout_default)`
`358`	`357`	`{`
`359`	`358`	`# An immediate shutdown may hide evidence of a locking bug. If`
`360`	`359`	`# retrying didn't resolve the issue, shut down in fast mode.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commiteaa1dd1

File tree

1 file changed

1 file changed

`‎src/test/recovery/t/019_replslot_limit.pl`

0 commit comments