Commitea849a2

committed

Add comment explaining that autoconf's failure to find getaddrinfo()

on Windows is now a feature, not a bug.

1 parent15df139 commitea849a2Copy full SHA for ea849a2

File tree

+11

-5

lines changed

+11

-5

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -14550,8 +14550,11 @@ done`
`14550`	`14550`
`14551`	`14551`
`14552`	`14552`
`14553`		`-# system's version of getaddrinfo(), if any, may be used only if we found`
`14554`		`-# a definition for struct addrinfo; see notes in src/include/getaddrinfo.h`
	`14553`	`+# System's version of getaddrinfo(), if any, may be used only if we found`
	`14554`	`+# a definition for struct addrinfo; see notes in src/include/getaddrinfo.h.`
	`14555`	`+# (Note: the AC_REPLACE_FUNCS probe fails on Windows, where the available`
	`14556`	`+# versions of getaddrinfo don't follow normal C call protocol. This is OK`
	`14557`	`+# because we want to use our own getaddrinfo.c on Windows anyway.)`
`14555`	`14558`	`if test x"$ac_cv_type_struct_addrinfo" = xyes ; then`
`14556`	`14559`
`14557`	`14560`	`for ac_func in getaddrinfo`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`dnl Process this file with autoconf to produce a configure script.`
`2`		`-dnl $PostgreSQL: pgsql/configure.in,v 1.424 2005/08/24 21:32:37 pgsql Exp $`
	`2`	`+dnl $PostgreSQL: pgsql/configure.in,v 1.425 2005/08/25 02:28:03 tgl Exp $`
`3`	`3`	`dnl`
`4`	`4`	`dnl Developers, please strive to achieve this order:`
`5`	`5`	`dnl`
`@@ -883,8 +883,11 @@ fi`
`883`	`883`
`884`	`884`	`AC_REPLACE_FUNCS([crypt fseeko getopt getrusage inet_aton random rint srandom strdup strerror strtol strtoul unsetenv])`
`885`	`885`
`886`		`-# system's version of getaddrinfo(), if any, may be used only if we found`
`887`		`-# a definition for struct addrinfo; see notes in src/include/getaddrinfo.h`
	`886`	`+# System's version of getaddrinfo(), if any, may be used only if we found`
	`887`	`+# a definition for struct addrinfo; see notes in src/include/getaddrinfo.h.`
	`888`	`+# (Note: the AC_REPLACE_FUNCS probe fails on Windows, where the available`
	`889`	`+# versions of getaddrinfo don't follow normal C call protocol. This is OK`
	`890`	`+# because we want to use our own getaddrinfo.c on Windows anyway.)`
`888`	`891`	`if test x"$ac_cv_type_struct_addrinfo" = xyes ; then`
`889`	`892`	`AC_REPLACE_FUNCS([getaddrinfo])`
`890`	`893`	`else`

Comments

(0)