NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitea7dace

committed

Simplify/speed up assertion cross-check in ginCompressPostingList().

I noticed while testing some other stuff that the CHECK_ENCODING_ROUNDTRIPlogic in ginCompressPostingList could account for over 50% of the runtimeof an INSERT with a GIN index. While that's not relevant to productionperformance, it's still kind of annoying in a debug build. Replacingthe loop around short memcmp's with one long memcmp works just as welland is significantly faster, at least on my machine.

1 parent7e39b96 commitea7daceCopy full SHA for ea7dace

File tree

1 file changed

-3

lines changed

src/backend/access/gin
- ginpostinglist.c

1 file changed

-3

lines changed

`‎src/backend/access/gin/ginpostinglist.c`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -266,11 +266,9 @@ ginCompressPostingList(const ItemPointer ipd, int nipd, int maxsize,`
`266`	`266`	`{`
`267`	`267`	`intndecoded;`
`268`	`268`	`ItemPointertmp=ginPostingListDecode(result,&ndecoded);`
`269`		`-inti;`
`270`	`269`
`271`	`270`	`Assert(ndecoded==totalpacked);`
`272`		`-for (i=0;i<ndecoded;i++)`
`273`		`-Assert(memcmp(&tmp[i],&ipd[i],sizeof(ItemPointerData))==0);`
	`271`	`+Assert(memcmp(tmp,ipd,ndecoded*sizeof(ItemPointerData))==0);`
`274`	`272`	`pfree(tmp);`
`275`	`273`	`}`
`276`	`274`	`#endif`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitea7dace

File tree

1 file changed

1 file changed

`‎src/backend/access/gin/ginpostinglist.c`

0 commit comments