Commitea72bc2

michaelpq

authored and

pull[bot]

committed

Remove double quotes from the second column of wait_event_names.txt

The double quotes used for the wait event names are not required, asthe values quoted are made of single words. The files generated bygenerate-wait_event_types.pl (pgstat_wait_event.c, wait_event_types.hand wait_event_types.sgml) are exactly the same before and after thiscommit, hence the wait event names and the enum elements have the samenames as before.Discussion:https://postgr.es/m/ZK9S3jFEV1X797Ll@paquier.xyz

1 parentdf943b9 commitea72bc2Copy full SHA for ea72bc2

File tree

2 files changed

+251

-249

lines changed

src/backend/utils/activity
- generate-wait_event_types.pl
- wait_event_names.txt

2 files changed

+251

-249

lines changed

`‎src/backend/utils/activity/generate-wait_event_types.pl‎`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@`
`73`	`73`	`foreachmy$line (@lines_sorted)`
`74`	`74`	`{`
`75`	`75`	`die"unable to parse wait_event_names.txt"`
`76`		`-unless$line =~/^(\w+)\t+(\w+)\t+("\w+")\t+("\w.*\.")$/;`
	`76`	`+unless$line =~/^(\w+)\t+(\w+)\t+(\w+)\t+("\w.*\.")$/;`
`77`	`77`
`78`	`78`	`(my$waitclassname,`
`79`	`79`	`my$waiteventenumname,`
`@@ -168,7 +168,9 @@`
`168`	`168`	`$firstpass = 0;`
`169`	`169`
`170`	`170`	`printf$c"\t\t case%s:\n",$wev->[0];`
`171`		`-printf$c"\t\t\t event_name =%s;\n\t\t\t break;\n",$wev->[1];`
	`171`	`+# Apply quotes to the wait event name string.`
	`172`	`+printf$c"\t\t\t event_name =\"%s\";\n\t\t\t break;\n",`
	`173`	`+$wev->[1];`
`172`	`174`	`}`
`173`	`175`
`174`	`176`	`printf$h"\n}$waitclass;\n\n";`
`@@ -221,7 +223,7 @@`
`221`	`223`	`{`
`222`	`224`	`printf$s" <row>\n";`
`223`	`225`	`printf$s" <entry><literal>%s</literal></entry>\n",`
`224`		`-substr$wev->[1], 1, -1;`
	`226`	`+$wev->[1];`
`225`	`227`	`printf$s" <entry>%s</entry>\n",substr$wev->[2], 1, -1;`
`226`	`228`	`printf$s" </row>\n";`
`227`	`229`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitea72bc2

File tree

2 files changed

2 files changed

`‎src/backend/utils/activity/generate-wait_event_types.pl‎`

0 commit comments