Commitea299d7

committed

Review wording on tablespaces w.r.t. partitioned tables

Remove a redundant comment, and document pg_class.reltablespace properlyin catalogs.sgml.After commitsa36c84c,8725958 and others.Backpatch to 12.Discussion:https://postgr.es/m/202403191013.w2kr7wqlamqz@alvherre.pgsql

1 parentd3d95f5 commitea299d7Copy full SHA for ea299d7

File tree

-7

lines changed

-7

lines changed

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1980,9 +1980,12 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l`
`1980`	`1980`	`(references <link linkend="catalog-pg-tablespace"><structname>pg_tablespace</structname></link>.<structfield>oid</structfield>)`
`1981`	`1981`	`</para>`
`1982`	`1982`	`<para>`
`1983`		`- The tablespace in which this relation is stored. If zero,`
`1984`		`- the database's default tablespace is implied. (Not meaningful`
`1985`		`- if the relation has no on-disk file.)`
	`1983`	`+ The tablespace in which this relation is stored.`
	`1984`	`+ If zero, the database's default tablespace is implied.`
	`1985`	`+ Not meaningful if the relation has no on-disk file,`
	`1986`	`+ except for partitioned tables, where this is the tablespace`
	`1987`	`+ in which partitions will be created when one is not`
	`1988`	`+ specified in the creation command.`
`1986`	`1989`	`</para></entry>`
`1987`	`1990`	`</row>`
`1988`	`1991`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -782,10 +782,6 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,`
`782`	`782`	`}`
`783`	`783`	`else if (stmt->partbound)`
`784`	`784`	`{`
`785`		`-/*`
`786`		`- * For partitions, when no other tablespace is specified, we default`
`787`		`- * the tablespace to the parent partitioned table's.`
`788`		`- */`
`789`	`785`	`Assert(list_length(inheritOids) == 1);`
`790`	`786`	`tablespaceId = get_rel_tablespace(linitial_oid(inheritOids));`
`791`	`787`	`}`

Comments

(0)