Commite9f5a06

committed

Don't use O_SYNC or similar when opening signal file to fsync it.

No need to use get_sync_bit() when we're calling pg_fsync() on the file.We're not writing to the files, so it doesn't make any difference inpractice, but seems less surprising this way.Reviewed-by: Andres FreundDiscussion:https://www.postgresql.org/message-id/b3b71061-4919-e882-4857-27e370ab134a%40iki.fi

1 parent0b8ea70 commite9f5a06Copy full SHA for e9f5a06

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5484,7 +5484,7 @@ readRecoverySignalFile(void)`
`5484`	`5484`	`{`
`5485`	`5485`	`intfd;`
`5486`	`5486`
`5487`		`-fd=BasicOpenFilePerm(STANDBY_SIGNAL_FILE,O_RDWR \|PG_BINARY \|get_sync_bit(sync_method),`
	`5487`	`+fd=BasicOpenFilePerm(STANDBY_SIGNAL_FILE,O_RDWR \|PG_BINARY,`
`5488`	`5488`	`S_IRUSR \|S_IWUSR);`
`5489`	`5489`	`if (fd >=0)`
`5490`	`5490`	`{`
`@@ -5497,7 +5497,7 @@ readRecoverySignalFile(void)`
`5497`	`5497`	`{`
`5498`	`5498`	`intfd;`
`5499`	`5499`
`5500`		`-fd=BasicOpenFilePerm(RECOVERY_SIGNAL_FILE,O_RDWR \|PG_BINARY \|get_sync_bit(sync_method),`
	`5500`	`+fd=BasicOpenFilePerm(RECOVERY_SIGNAL_FILE,O_RDWR \|PG_BINARY,`
`5501`	`5501`	`S_IRUSR \|S_IWUSR);`
`5502`	`5502`	`if (fd >=0)`
`5503`	`5503`	`{`

Comments

(0)