NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite9c81b6

committed

Remove --verbose from PROVE_FLAGS

Per discussion, the TAP tests are really more verbose than necessary, soremove the --verbose flag from PROVE_FLAGS. Also add comments to letfolks know how they can enable it if they really wish to, as suggestedby Craig Ringer.Author: Michael Paquier, additional comments by me.Discussion:https://postgr.es/m/CAMsr%2BYGAzcMDOZ_BirnMCL6Sb%3DMUjP0FRE82YBDSbXcf6pm9Yg%40mail.gmail.com

1 parentfe7bbc4 commite9c81b6Copy full SHA for e9c81b6

File tree

2 files changed

-1

lines changed

src
- Makefile.global.in
- test/perl
  - README

2 files changed

-1

lines changed

`‎src/Makefile.global.in`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,8 @@ PROVE = @PROVE@`
`339`	`339`	`# There are common routines in src/test/perl, and some test suites have`
`340`	`340`	`# extra perl modules in their own directory.`
`341`	`341`	`PG_PROVE_FLAGS = -I$(top_srcdir)/src/test/perl/ -I$(srcdir)`
`342`		`-PROVE_FLAGS = --verbose`
	`342`	`+# For more info, add to your make line: PROVE_FLAGS='--verbose'`
	`343`	`+PROVE_FLAGS =`
`343`	`344`
`344`	`345`	`# prepend to path if already set, else just set it`
`345`	`346`	`defineadd_to_path`

`‎src/test/perl/README`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,11 @@ src/test/ssl, or should be added to one of the suites for an existing utility.`
`20`	`20`	`Note that all tests and test tools should have perltidy run on them before`
`21`	`21`	`patches are submitted, using perltidy --profile=src/tools/pgindent/perltidyrc`
`22`	`22`
	`23`	`+By default, to keep the noise low during runs, we do not set any flags via`
	`24`	`+PROVE_FLAGS, but this can be done on the 'make' command line if desired, eg:`
	`25`	`+`
	`26`	`+make check-world PROVE_FLAGS='--verbose'`
	`27`	`+`
`23`	`28`	`Writing tests`
`24`	`29`	`-------------`
`25`	`30`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite9c81b6

File tree

2 files changed

2 files changed

`‎src/Makefile.global.in`

`‎src/test/perl/README`

0 commit comments