NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite8f201a

committed

Remove overzealous VACUUM failsafe assertions.

The failsafe can trigger when index processing is already disabled.This can happen when VACUUM's INDEX_CLEANUP parameter is "off" and thefailsafe happens to trigger. Remove assertions that assume that indexprocessing is directly tied to the failsafe.Oversight in commitc242baa, which made it possible for the failsafe totrigger in a two-pass strategy VACUUM that has yet to make its firstcall to lazy_vacuum_all_indexes().

1 parent9679517 commite8f201aCopy full SHA for e8f201a

File tree

1 file changed

-4

lines changed

src/backend/access/heap
- vacuumlazy.c

1 file changed

-4

lines changed

`‎src/backend/access/heap/vacuumlazy.c`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1162,7 +1162,8 @@ lazy_scan_heap(LVRelState vacrel, VacuumParams params, bool aggressive)`
`1162`	`1162`	`* There is a similar check inside lazy_vacuum_all_indexes(), but`
`1163`	`1163`	`* relfrozenxid might start to look dangerously old before we reach`
`1164`	`1164`	`* that point. This check also provides failsafe coverage for the`
`1165`		`- * one-pass strategy case.`
	`1165`	`+ * one-pass strategy, and the two-pass strategy with the index_cleanup`
	`1166`	`+ * param set to 'off'.`
`1166`	`1167`	`*/`
`1167`	`1168`	`if (blkno-next_failsafe_block >=FAILSAFE_EVERY_PAGES)`
`1168`	`1169`	`{`
`@@ -2611,9 +2612,6 @@ lazy_check_wraparound_failsafe(LVRelState *vacrel)`
`2611`	`2612`	`if (unlikely(vacuum_xid_failsafe_check(vacrel->relfrozenxid,`
`2612`	`2613`	`vacrel->relminmxid)))`
`2613`	`2614`	`{`
`2614`		`-Assert(vacrel->do_index_vacuuming);`
`2615`		`-Assert(vacrel->do_index_cleanup);`
`2616`		`-`
`2617`	`2615`	`vacrel->failsafe_active= true;`
`2618`	`2616`
`2619`	`2617`	`/* Disable index vacuuming, index cleanup, and heap rel truncation */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite8f201a

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/vacuumlazy.c`

0 commit comments