Commite8eb485

committed

Initialize dblink remoteConn struct in all cases

Two of the members of rconn were left uninitialized. Whendblink_open() is called without an outer transaction ithandles the initialization for us, but with an outertransaction it does not. Arrange for initializationin all cases. Backpatch to all supported versions.Reported-by: Alexander LakhinDiscussion:https://www.postgresql.org/message-id/flat/9bd0744f-5f04-c778-c5b3-809efe9c30c7%40joeconway.com#c545909a41664991aca60c4d70a10ce7

1 parent3ccae54 commite8eb485Copy full SHA for e8eb485

File tree

-0

lines changed

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -273,8 +273,13 @@ dblink_connect(PG_FUNCTION_ARGS)`
`273`	`273`	`conname_or_str=text_to_cstring(PG_GETARG_TEXT_PP(0));`
`274`	`274`
`275`	`275`	`if (connname)`
	`276`	`+{`
`276`	`277`	`rconn= (remoteConn*)MemoryContextAlloc(TopMemoryContext,`
`277`	`278`	`sizeof(remoteConn));`
	`279`	`+rconn->conn=NULL;`
	`280`	`+rconn->openCursorCount=0;`
	`281`	`+rconn->newXactForCursor= false;`
	`282`	`+}`
`278`	`283`
`279`	`284`	`/* first check for valid foreign data server */`
`280`	`285`	`connstr=get_connect_string(conname_or_str);`

Comments

(0)