Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commite8e1f96

Browse files
committed
Fix make maintainer-clean with queryjumblefuncs.*.c files in src/backend/nodes/
The files generated by gen_node_support.pl for query jumbling(queryjumblefuncs.funcs.c and queryjumblefuncs.switch.c) were not beingremoved on make maintainer-clean (they need to remain around after asimple "clean"). This commit makes the operation consistent with thecopy, equal, out and read files.While on it, update a comment in the nodes'README where a reference toqueryjumblefuncs.funcs.c was missing.Reported-by: Nathan BossartReviewed-by: Richard Guo, Daniel GustafssonDiscussion:https://postgr.es/m/ZBgAfTHcL6W7zGdW@paquier.xyz
1 parentb94c671 commite8e1f96

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

‎src/backend/nodes/Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@ $(top_builddir)/src/include/nodes/header-stamp: node-support-stamp
9595
copyfuncs.o: copyfuncs.c copyfuncs.funcs.c copyfuncs.switch.c | node-support-stamp
9696
equalfuncs.o: equalfuncs.c equalfuncs.funcs.c equalfuncs.switch.c | node-support-stamp
9797
outfuncs.o: outfuncs.c outfuncs.funcs.c outfuncs.switch.c | node-support-stamp
98+
queryjumblefuncs.o: queryjumblefuncs.c queryjumblefuncs.funcs.c queryjumblefuncs.switch.c | node-support-stamp
9899
readfuncs.o: readfuncs.c readfuncs.funcs.c readfuncs.switch.c | node-support-stamp
99100

100101
maintainer-clean: clean
101-
rm -f node-support-stamp$(addsuffix funcs.funcs.c,copy equal out read)$(addsuffix funcs.switch.c,copy equal out read) nodetags.h
102+
rm -f node-support-stamp$(addsuffix funcs.funcs.c,copy equal outqueryjumbleread)$(addsuffix funcs.switch.c,copy equal out queryjumble read) nodetags.h

‎src/backend/nodes/README

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,10 @@ Suppose you want to define a node Foo:
8888
If you intend to inherit from, say a Plan node, put Plan as the first field
8989
of your struct definition. (The T_Foo tag is created automatically.)
9090
2. Check that the generated support functions in copyfuncs.funcs.c,
91-
equalfuncs.funcs.c, outfuncs.funcs.c and readfuncs.funcs.clook
92-
correct. Add attributes as necessary to control the outcome. (For
93-
some classes of node types, you don't need allfour support functions.
94-
Use node attributes similar to those of related node types.)
91+
equalfuncs.funcs.c, outfuncs.funcs.c, queryjumblefuncs.funcs.cand
92+
readfuncs.funcs.c lookcorrect. Add attributes as necessary to control the
93+
outcome. (Forsome classes of node types, you don't need allthe support
94+
functions.Use node attributes similar to those of related node types.)
9595
3. Add cases to the functions in nodeFuncs.c as needed. There are many
9696
other places you'll probably also need to teach about your new node
9797
type. Best bet is to grep for references to one or two similar existing

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp