forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commite89f14e
committed
Refactor index cost estimation functions in view of IndexClause changes.
Get rid of deconstruct_indexquals() in favor of just iterating over theIndexClause list directly. The extra services that that function used toprovide, such as hiding clause commutation and associating the right indexcolumn with each clause, are no longer useful given the new data structure.I'd originally thought that it'd provide a useful amount of abstractionby freeing callers from paying attention to the exact clause type of eachindexqual, but that hope proves to have been vain, because few callers canignore the semantic differences between different clause types. Indeed,removing it results in a net code savings, and probably some cycles shavedby not having to build an extra list-of-structs data structure.Also, export a few formerly-static support functions, with the goalof allowing extension AMs to write functionality equivalent togenericcostestimate() without pointless code duplication.Discussion:https://postgr.es/m/24586.1550106354@sss.pgh.pa.us1 parentfc6c727 commite89f14e
File tree
3 files changed
+172
-233
lines changed- contrib/bloom
- src
- backend/utils/adt
- include/utils
3 files changed
+172
-233
lines changedLines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | 30 | | |
32 | 31 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | 32 | | |
37 | 33 | | |
38 | 34 | | |
39 | 35 | | |
40 | 36 | | |
41 | 37 | | |
42 | | - | |
| 38 | + | |
43 | 39 | | |
44 | 40 | | |
45 | 41 | | |
| |||
0 commit comments
Comments
(0)