NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite8240db

committed

Fix pg_rewind debug output to print the source timeline history

getTimelineHistory() is called twice, to read the source and thetarget timeline history files. However, the loop to print the filewith the --debug option used the wrong variable when dealing with thesource. As a result, the source's history was always printed as empty.Spotted while debugging bug #18575, but this does not fix that bug,just the debugging output. Backpatch to all supported versions.Discussion:https://www.postgresql.org/message-id/092dd515-b7b4-4fd0-8407-ceca2f02f6ec@iki.fi

1 parentee2997c commite8240dbCopy full SHA for e8240db

File tree

1 file changed

-4

lines changed

src/bin/pg_rewind
- pg_rewind.c

1 file changed

-4

lines changed

`‎src/bin/pg_rewind/pg_rewind.c`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -873,6 +873,7 @@ getTimelineHistory(TimeLineID tli, bool is_source, int *nentries)`
`873`	`873`	`pg_free(histfile);`
`874`	`874`	`}`
`875`	`875`
	`876`	`+/* In debugging mode, print what we read */`
`876`	`877`	`if (debug)`
`877`	`878`	`{`
`878`	`879`	`inti;`
`@@ -882,10 +883,7 @@ getTimelineHistory(TimeLineID tli, bool is_source, int *nentries)`
`882`	`883`	`else`
`883`	`884`	`pg_log_debug("Target timeline history:");`
`884`	`885`
`885`		`-/*`
`886`		`- * Print the target timeline history.`
`887`		`- */`
`888`		`-for (i=0;i<targetNentries;i++)`
	`886`	`+for (i=0;i<*nentries;i++)`
`889`	`887`	`{`
`890`	`888`	`TimeLineHistoryEntry*entry;`
`891`	`889`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite8240db

File tree

1 file changed

1 file changed

`‎src/bin/pg_rewind/pg_rewind.c`

0 commit comments