NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite7f7cf4

committed

1. LocalBufferSync(): set nextFreeLocalBuf to 0 - we're freeing

all local buffers @ xact commit, so accordingly nextFreeLocalBuf is first local buffer now. It helps to avoid unnecessary local buffer allocations in LocalBufferAlloc() latter ("memmory leaks" in 'order by').2. ResetLocalBufferPool() lost allocated local buffers: memset(LocalBufferDescriptors, 0, sizeof(BufferDesc) * NLocBuffer); (local buffers leak @ xact aborts).

1 parent4a8c3dd commite7f7cf4Copy full SHA for e7f7cf4

File tree

1 file changed

-6

lines changed

src/backend/storage/buffer
- localbuf.c

1 file changed

-6

lines changed

`‎src/backend/storage/buffer/localbuf.c`

Lines changed: 7 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`*`
`16`	`16`	`*`
`17`	`17`	`* IDENTIFICATION`
`18`		`- * $Header: /cvsroot/pgsql/src/backend/storage/buffer/localbuf.c,v 1.6 1997/04/18 02:53:37 vadim Exp $`
	`18`	`+ * $Header: /cvsroot/pgsql/src/backend/storage/buffer/localbuf.c,v 1.7 1997/05/20 11:30:32 vadim Exp $`
`19`	`19`	`*`
`20`	`20`	`*-------------------------------------------------------------------------`
`21`	`21`	`*/`
`@@ -273,22 +273,23 @@ LocalBufferSync(void)`
`273`	`273`	`}`
`274`	`274`
`275`	`275`	`memset(LocalRefCount,0,sizeof(long)*NLocBuffer);`
	`276`	`+nextFreeLocalBuf=0;`
`276`	`277`	`}`
`277`	`278`
`278`	`279`	`void`
`279`	`280`	`ResetLocalBufferPool(void)`
`280`	`281`	`{`
`281`	`282`	`inti;`
`282`	`283`
`283`		`-memset(LocalBufferDescriptors,0,sizeof(BufferDesc)*NLocBuffer);`
`284`		`-nextFreeLocalBuf=0;`
`285`		`-`
`286`		`-for (i=0;i<NLocBuffer;i++) {`
	`284`	`+for (i=0;i<NLocBuffer;i++)`
	`285`	`+ {`
`287`	`286`	`BufferDesc*buf=&LocalBufferDescriptors[i];`
`288`	`287`
`289`		`-/* just like InitLocalBuffer() */`
	`288`	`+buf->tag.relId.relId=InvalidOid;`
	`289`	`+buf->flags &= ~BM_DIRTY;`
`290`	`290`	`buf->buf_id=-i-2;`
`291`	`291`	`}`
`292`	`292`
`293`	`293`	`memset(LocalRefCount,0,sizeof(long)*NLocBuffer);`
	`294`	`+nextFreeLocalBuf=0;`
`294`	`295`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite7f7cf4

File tree

1 file changed

1 file changed

`‎src/backend/storage/buffer/localbuf.c`

0 commit comments