Commite7e7da2

committed

Fix possible logical replication crash.

Commitc3afe8c added a newpassword_required option but forgot that you need database accessto check whether an arbitrary role ID is a superuser.Report and patch by Hou Zhijie. I added a comment. Thanks toAlexander Lakhin for devising a way to reproduce the crash.Discussion:http://postgr.es/m/OS0PR01MB5716BFD7EC44284C89F40808948F9@OS0PR01MB5716.jpnprd01.prod.outlook.com

1 parenta8a0012 commite7e7da2Copy full SHA for e7e7da2

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4545,12 +4545,14 @@ ApplyWorkerMain(Datum main_arg)`
`4545`	`4545`	`replorigin_session_setup(originid,0);`
`4546`	`4546`	`replorigin_session_origin=originid;`
`4547`	`4547`	`origin_startpos=replorigin_session_get_progress(false);`
`4548`		`-CommitTransactionCommand();`
`4549`	`4548`
`4550`	`4549`	`/* Is the use of a password mandatory? */`
`4551`	`4550`	`must_use_password=MySubscription->passwordrequired&&`
`4552`	`4551`	`!superuser_arg(MySubscription->owner);`
`4553`	`4552`
	`4553`	`+/* Note that the superuser_arg call can access the DB */`
	`4554`	`+CommitTransactionCommand();`
	`4555`	`+`
`4554`	`4556`	`LogRepWorkerWalRcvConn=walrcv_connect(MySubscription->conninfo, true,`
`4555`	`4557`	`must_use_password,`
`4556`	`4558`	`MySubscription->name,&err);`

Comments

(0)