NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite730718

committed

Use the macro, not handwritten code, to construct anymultirange_in().

Apparently anymultirange_in was written before we converted allthese pseudotype input functions to use a common macro, and it didn'tget fixed before committing. Sloppy merging probably explains itsunintuitive ordering, too, so rearrange.Noted while surveying datatype input functions to see what wehave left to fix. I'm inclined to leave the pseudotypes asthrowing hard errors, because it's difficult to see a reason whyanyone would need something else. But in any case, if we wantto change that, we shouldn't have to change multiple copies ofthe code.

1 parent94985c2 commite730718Copy full SHA for e730718

File tree

1 file changed

-19

lines changed

src/backend/utils/adt
- pseudotypes.c

1 file changed

-19

lines changed

`‎src/backend/utils/adt/pseudotypes.c`

Lines changed: 8 additions & 19 deletions

Original file line number	Diff line number	Diff line change
`@@ -229,38 +229,27 @@ anycompatiblerange_out(PG_FUNCTION_ARGS)`
`229`	`229`	`}`
`230`	`230`
`231`	`231`	`/*`
`232`		`- *anycompatiblemultirange`
	`232`	`+ *anymultirange`
`233`	`233`	`*`
`234`	`234`	`* We may as well allow output, since multirange_out will in fact work.`
`235`	`235`	`*/`
`236`		`-PSEUDOTYPE_DUMMY_INPUT_FUNC(anycompatiblemultirange);`
	`236`	`+PSEUDOTYPE_DUMMY_INPUT_FUNC(anymultirange);`
`237`	`237`
`238`	`238`	`Datum`
`239`		`-anycompatiblemultirange_out(PG_FUNCTION_ARGS)`
	`239`	`+anymultirange_out(PG_FUNCTION_ARGS)`
`240`	`240`	`{`
`241`	`241`	`returnmultirange_out(fcinfo);`
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`/*`
`245`		`- * anymultirange_in- input routine for pseudo-type ANYMULTIRANGE.`
`246`		`- */`
`247`		`-Datum`
`248`		`-anymultirange_in(PG_FUNCTION_ARGS)`
`249`		`-{`
`250`		`-ereport(ERROR,`
`251`		`-(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
`252`		`-errmsg("cannot accept a value of type %s","anymultirange")));`
`253`		`-`
`254`		`-PG_RETURN_VOID();/* keep compiler quiet */`
`255`		`-}`
`256`		`-`
`257`		`-/*`
`258`		`- * anymultirange_out- output routine for pseudo-type ANYMULTIRANGE.`
	`245`	`+ * anycompatiblemultirange`
`259`	`246`	`*`
`260`		`- * We may as well allowthis, since multirange_out will in fact work.`
	`247`	`+ * We may as well allowoutput, since multirange_out will in fact work.`
`261`	`248`	`*/`
	`249`	`+PSEUDOTYPE_DUMMY_INPUT_FUNC(anycompatiblemultirange);`
	`250`	`+`
`262`	`251`	`Datum`
`263`		`-anymultirange_out(PG_FUNCTION_ARGS)`
	`252`	`+anycompatiblemultirange_out(PG_FUNCTION_ARGS)`
`264`	`253`	`{`
`265`	`254`	`returnmultirange_out(fcinfo);`
`266`	`255`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite730718

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/pseudotypes.c`

0 commit comments