NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite70813f

committed

set_deparse_plan: Reuse variable to appease Coverity

Coverity complains that dpns->outer_plan is deferenced (to obtain->targetlist) when possibly NULL. We can avoid this by usingdpns->outer_tlist instead, which was already obtained a few lines up.The fact that we end up with dpns->inner_tlist = dpns->outer_tlistis a bit suspicious-looking and maybe worthy of more investigation, butI'll leave that for another day.Reviewed-by: Michaël Paquier <michael@paquier.xyz>Discussion:https://postgr.es/m/202204191345.qerjy3kxi3eb@alvherre.pgsql

1 parenta87e759 commite70813fCopy full SHA for e70813f

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- ruleutils.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/ruleutils.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4996,7 +4996,7 @@ set_deparse_plan(deparse_namespace dpns, Plan plan)`
`4996`	`4996`	`if (IsA(plan,ModifyTable))`
`4997`	`4997`	`{`
`4998`	`4998`	`if (((ModifyTable*)plan)->operation==CMD_MERGE)`
`4999`		`-dpns->inner_tlist=dpns->outer_plan->targetlist;`
	`4999`	`+dpns->inner_tlist=dpns->outer_tlist;`
`5000`	`5000`	`else`
`5001`	`5001`	`dpns->inner_tlist= ((ModifyTable*)plan)->exclRelTlist;`
`5002`	`5002`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite70813f

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/ruleutils.c`

0 commit comments