Commite6f5d1a

committed

Drop const cast from dlsym() calls

This workaround might be obsolete. We'll see if those "olderplatforms" mentioned in the comment are still around.Discussion:https://www.postgresql.org/message-id/08adbe4e-38f8-2c73-55f0-591392371687%402ndquadrant.com

1 parent807e4bc commite6f5d1aCopy full SHA for e6f5d1a

File tree

-8

lines changed

-8

lines changed

Lines changed: 3 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -121,12 +121,8 @@ load_external_function(const char filename, const char funcname,`
`121`	`121`	`if (filehandle)`
`122`	`122`	`*filehandle=lib_handle;`
`123`	`123`
`124`		`-/*`
`125`		`- * Look up the function within the library. According to POSIX dlsym()`
`126`		`- * should declare its second argument as "const char *", but older`
`127`		`- * platforms might not, so for the time being we just cast away const.`
`128`		`- */`
`129`		`-retval= (PGFunction)dlsym(lib_handle, (char*)funcname);`
	`124`	`+/* Look up the function within the library. */`
	`125`	`+retval= (PGFunction)dlsym(lib_handle,funcname);`
`130`	`126`
`131`	`127`	`if (retval==NULL&&signalNotFound)`
`132`	`128`	`ereport(ERROR,`
`@@ -174,8 +170,7 @@ load_file(const char *filename, bool restricted)`
`174`	`170`	`PGFunction`
`175`	`171`	`lookup_external_function(voidfilehandle,constcharfuncname)`
`176`	`172`	`{`
`177`		`-/* as above, cast away const for the time being */`
`178`		`-return (PGFunction)dlsym(filehandle, (char*)funcname);`
	`173`	`+return (PGFunction)dlsym(filehandle,funcname);`
`179`	`174`	`}`
`180`	`175`
`181`	`176`

Comments

(0)