NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite6ccd1c

committed

Simplify one use of ScanKey in pg_subscription.c

The section of the code in charge of returning all the relationsassociated to a subscription only need one ScanKey, but allocated two ofthem. This code was introduced as a copy-paste from a different area onthe same file by7c4f524, making the result confusing to follow.Author: Peter SmithReviewed-by: Tom Lane, Julien Rouhaud, Bharath RupireddyDiscussion:https://postgr.es/m/CAHut+PsLKe+rN3FjchoJsd76rx2aMsFTB7CTFxRgUP05p=kcpQ@mail.gmail.com

1 parentec6e70c commite6ccd1cCopy full SHA for e6ccd1c

File tree

1 file changed

-4

lines changed

src/backend/catalog
- pg_subscription.c

1 file changed

-4

lines changed

`‎src/backend/catalog/pg_subscription.c`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -461,19 +461,18 @@ GetSubscriptionRelations(Oid subid)`
`461`	`461`	`List*res=NIL;`
`462`	`462`	`Relationrel;`
`463`	`463`	`HeapTupletup;`
`464`		`-intnkeys=0;`
`465`		`-ScanKeyDataskey[2];`
	`464`	`+ScanKeyDataskey[1];`
`466`	`465`	`SysScanDescscan;`
`467`	`466`
`468`	`467`	`rel=table_open(SubscriptionRelRelationId,AccessShareLock);`
`469`	`468`
`470`		`-ScanKeyInit(&skey[nkeys++],`
	`469`	`+ScanKeyInit(&skey[0],`
`471`	`470`	`Anum_pg_subscription_rel_srsubid,`
`472`	`471`	`BTEqualStrategyNumber,F_OIDEQ,`
`473`	`472`	`ObjectIdGetDatum(subid));`
`474`	`473`
`475`	`474`	`scan=systable_beginscan(rel,InvalidOid, false,`
`476`		`-NULL,nkeys,skey);`
	`475`	`+NULL,1,skey);`
`477`	`476`
`478`	`477`	`while (HeapTupleIsValid(tup=systable_getnext(scan)))`
`479`	`478`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite6ccd1c

File tree

1 file changed

1 file changed

`‎src/backend/catalog/pg_subscription.c`

0 commit comments