Commite6c4e01

committed

Review wording on tablespaces w.r.t. partitioned tables

Remove a redundant comment, and document pg_class.reltablespace properlyin catalogs.sgml.After commitsa36c84c,8725958 and others.Backpatch to 12.Discussion:https://postgr.es/m/202403191013.w2kr7wqlamqz@alvherre.pgsql

1 parent1f4eb73 commite6c4e01Copy full SHA for e6c4e01

File tree

-7

lines changed

-7

lines changed

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2010,9 +2010,12 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l`
`2010`	`2010`	`(references <link linkend="catalog-pg-tablespace"><structname>pg_tablespace</structname></link>.<structfield>oid</structfield>)`
`2011`	`2011`	`</para>`
`2012`	`2012`	`<para>`
`2013`		`- The tablespace in which this relation is stored. If zero,`
`2014`		`- the database's default tablespace is implied. (Not meaningful`
`2015`		`- if the relation has no on-disk file.)`
	`2013`	`+ The tablespace in which this relation is stored.`
	`2014`	`+ If zero, the database's default tablespace is implied.`
	`2015`	`+ Not meaningful if the relation has no on-disk file,`
	`2016`	`+ except for partitioned tables, where this is the tablespace`
	`2017`	`+ in which partitions will be created when one is not`
	`2018`	`+ specified in the creation command.`
`2016`	`2019`	`</para></entry>`
`2017`	`2020`	`</row>`
`2018`	`2021`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -785,10 +785,6 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,`
`785`	`785`	`}`
`786`	`786`	`else if (stmt->partbound)`
`787`	`787`	`{`
`788`		`-/*`
`789`		`- * For partitions, when no other tablespace is specified, we default`
`790`		`- * the tablespace to the parent partitioned table's.`
`791`		`- */`
`792`	`788`	`Assert(list_length(inheritOids) == 1);`
`793`	`789`	`tablespaceId = get_rel_tablespace(linitial_oid(inheritOids));`
`794`	`790`	`}`

Comments

(0)