@@ -1956,6 +1956,8 @@ canAcceptConnections(void)
19561956
19571957/*
19581958 * ConnCreate -- create a local connection data structure
1959+ *
1960+ * Returns NULL on failure, other than out-of-memory which is fatal.
19591961 */
19601962static Port *
19611963ConnCreate (int serverFd )
@@ -1977,17 +1979,15 @@ ConnCreate(int serverFd)
19771979ConnFree (port );
19781980return NULL ;
19791981}
1980- else
1981- {
1982- /*
1983- * Precompute password salt values to use for this connection. It's
1984- * slightly annoying to do this long in advance of knowing whether
1985- * we'll need 'em or not, but we must do the random() calls before we
1986- * fork, not after. Else the postmaster's random sequence won't get
1987- * advanced, and all backends would end up using the same salt...
1988- */
1989- RandomSalt (port -> md5Salt );
1990- }
1982+
1983+ /*
1984+ * Precompute password salt values to use for this connection. It's
1985+ * slightly annoying to do this long in advance of knowing whether
1986+ * we'll need 'em or not, but we must do the random() calls before we
1987+ * fork, not after. Else the postmaster's random sequence won't get
1988+ * advanced, and all backends would end up using the same salt...
1989+ */
1990+ RandomSalt (port -> md5Salt );
19911991
19921992/*
19931993 * Allocate GSSAPI specific state struct