NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite66fcce

Neil Conway

committed

Use memmove() rather than memcpy() in set_var_from_var(). If this function

is asked to assign a variable to itself, it will result in doing amemcpy() on an entirely-overlapping memory range, which results inundefined behavior according to ANSI C. That said, it is unlikely toactually do anything bad on any sane libc, but this keeps valgrind quiet.

1 parentd391718 commite66fcceCopy full SHA for e66fcce

File tree

1 file changed

-2

lines changed

src/backend/utils/adt
- numeric.c

1 file changed

-2

lines changed

`‎src/backend/utils/adt/numeric.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`* Copyright (c) 1998-2003, PostgreSQL Global Development Group`
`15`	`15`	`*`
`16`	`16`	`* IDENTIFICATION`
`17`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/numeric.c,v 1.70 2003/12/02 00:26:59 tgl Exp $`
	`17`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/numeric.c,v 1.71 2004/02/04 01:11:47 neilc Exp $`
`18`	`18`	`*`
`19`	`19`	`*-------------------------------------------------------------------------`
`20`	`20`	`*/`
`@@ -2729,7 +2729,7 @@ set_var_from_var(NumericVar value, NumericVar dest)`
`2729`	`2729`
`2730`	`2730`	`digitbuf_free(dest->buf);`
`2731`	`2731`
`2732`		`-memcpy(dest,value,sizeof(NumericVar));`
	`2732`	`+memmove(dest,value,sizeof(NumericVar));`
`2733`	`2733`	`dest->buf=newbuf;`
`2734`	`2734`	`dest->digits=newbuf+1;`
`2735`	`2735`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite66fcce

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/numeric.c`

0 commit comments