Commite647890

authored and

committed

Fix erroneous -Werror=missing-braces on old GCC

The buildfarm reports that this is an error on gcc (Debian 4.7.2-5)4.7.2, 32-bit. The bug seems to be GCC bug 53119, which has obviouslybeen fixed for years.Author: Tristan Partin <tristan@neon.tech>Discussion:https://www.postgresql.org/message-id/flat/CT6HJ3U8068R.3A8SJMV02D9BC@gonk

1 parent47159fd commite647890Copy full SHA for e647890

File tree

-1

lines changed

-1

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2239,10 +2239,15 @@ evalStandardFunc(CState *st,`
`2239`	`2239`	`{`
`2240`	`2240`	`/* evaluate all function arguments */`
`2241`	`2241`	`intnargs=0;`
`2242`		`-PgBenchValuevargs[MAX_FARGS]= {0 };`
`2243`	`2242`	`PgBenchExprLink*l=args;`
`2244`	`2243`	`boolhas_null= false;`
`2245`	`2244`
	`2245`	`+/*`
	`2246`	`+ * This value is double braced to workaround GCC bug 53119, which seems to`
	`2247`	`+ * exist at least on gcc (Debian 4.7.2-5) 4.7.2, 32-bit.`
	`2248`	`+ */`
	`2249`	`+PgBenchValuevargs[MAX_FARGS]= { {0 } };`
	`2250`	`+`
`2246`	`2251`	`for (nargs=0;nargs<MAX_FARGS&&l!=NULL;nargs++,l=l->next)`
`2247`	`2252`	`{`
`2248`	`2253`	`if (!evaluateExpr(st,l->expr,&vargs[nargs]))`

Comments

(0)