NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite5b7451

committed

Fix possible leak of semaphore count.

Commit4aec498 reorganized the orderof operations here so that we no longer increment the number of "extrawaits" before locking the semaphore, but it did not change thestarting value of extraWaits from 0 to -1 to compensate. In the worstcase, this could leak a semaphore count, but that seems to be unlikelyin practice.Discussion:http://postgr.es/m/CAA4eK1JyVqXiMba+-a589Rk0pyHsyKkGxeumVKjU6Y74hdrVLQ@mail.gmail.comAmit Kapila, per an off-list report by Dilip Kumar. Reviewed by me.

1 parent933b466 commite5b7451Copy full SHA for e5b7451

File tree

1 file changed

-1

lines changed

src/backend/storage/ipc
- procarray.c

1 file changed

-1

lines changed

`‎src/backend/storage/ipc/procarray.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -484,7 +484,6 @@ ProcArrayGroupClearXid(PGPROC *proc, TransactionId latestXid)`
`484`	`484`	`volatilePROC_HDR*procglobal=ProcGlobal;`
`485`	`485`	`uint32nextidx;`
`486`	`486`	`uint32wakeidx;`
`487`		`-intextraWaits=-1;`
`488`	`487`
`489`	`488`	`/* We should definitely have an XID to clear. */`
`490`	`489`	`Assert(TransactionIdIsValid(allPgXact[proc->pgprocno].xid));`
`@@ -511,6 +510,8 @@ ProcArrayGroupClearXid(PGPROC *proc, TransactionId latestXid)`
`511`	`510`	`*/`
`512`	`511`	`if (nextidx!=INVALID_PGPROCNO)`
`513`	`512`	`{`
	`513`	`+intextraWaits=0;`
	`514`	`+`
`514`	`515`	`/* Sleep until the leader clears our XID. */`
`515`	`516`	`for (;;)`
`516`	`517`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite5b7451

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/procarray.c`

0 commit comments