NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite578c17

committed

Fix compilation warning in unicode_norm.c

80f8eb7 has introduced in unicode_norm.c some new code that useshtonl(). On at least some FreeBSD environments, it is possible to findthat this function is undeclared, causing a compilation warning. It isworth noting that no buildfarm members have reported this issue.Instead of adding a new inclusion to arpa/inet.h, switch to usethe equivalent defined in pg_bswap.h, to benefit from any built-infunction if the compiler has one.Reported-by: Masahiko SawadaDiscussion:https://postgr.es/m/CA+fd4k7D4b12ShywWj=AbcHZzV1-OqMjNe7RZAu+tgz5rd_11A@mail.gmail.com

1 parentf0f13a3 commite578c17Copy full SHA for e578c17

File tree

1 file changed

-1

lines changed

src/common
- unicode_norm.c

1 file changed

-1

lines changed

`‎src/common/unicode_norm.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`	`#ifndefFRONTEND`
`24`	`24`	`#include"common/unicode_normprops_table.h"`
`25`	`25`	`#endif`
	`26`	`+#include"port/pg_bswap.h"`
`26`	`27`
`27`	`28`	`#ifndefFRONTEND`
`28`	`29`	`#defineALLOC(size) palloc(size)`
`@@ -475,7 +476,7 @@ qc_hash_lookup(pg_wchar ch, const pg_unicode_norminfo *norminfo)`
`475`	`476`	`* Compute the hash function. The hash key is the codepoint with the bytes`
`476`	`477`	`* in network order.`
`477`	`478`	`*/`
`478`		`-hashkey=htonl(ch);`
	`479`	`+hashkey=pg_hton32(ch);`
`479`	`480`	`h=norminfo->hash(&hashkey);`
`480`	`481`
`481`	`482`	`/* An out-of-range result implies no match */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite578c17

File tree

1 file changed

1 file changed

`‎src/common/unicode_norm.c`

0 commit comments