NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite4d9212

committed

pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.

The additional newline seems to have accidentally been introduced in2c03216, in 9.5. The newline is only issued when an FPW ispresent for the block reference.While there could be an argument that removing the newlines in theback branches could cause a problem for somebody parsing thepg_waldump output, the likelihood of that seems small enough. It seemsat least equally likely that the randomness of when newlines areissued causes problems.Author: Andres FreundDiscussion:https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.deBackpatch: 9.5, like2c03216.

1 parente0f76f2 commite4d9212Copy full SHA for e4d9212

File tree

1 file changed

-2

lines changed

src/bin/pg_waldump
- pg_waldump.c

1 file changed

-2

lines changed

`‎src/bin/pg_waldump/pg_waldump.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -584,7 +584,7 @@ XLogDumpDisplayRecord(XLogDumpConfig config, XLogReaderState record)`
`584`	`584`	`BKPIMAGE_IS_COMPRESSED)`
`585`	`585`	`{`
`586`	`586`	`printf(" (FPW%s); hole: offset: %u, length: %u, "`
`587`		`-"compression saved: %u\n",`
	`587`	`+"compression saved: %u",`
`588`	`588`	`XLogRecBlockImageApply(record,block_id) ?`
`589`	`589`	`"" :" for WAL verification",`
`590`	`590`	`record->blocks[block_id].hole_offset,`
`@@ -595,7 +595,7 @@ XLogDumpDisplayRecord(XLogDumpConfig config, XLogReaderState record)`
`595`	`595`	`}`
`596`	`596`	`else`
`597`	`597`	`{`
`598`		`-printf(" (FPW%s); hole: offset: %u, length: %u\n",`
	`598`	`+printf(" (FPW%s); hole: offset: %u, length: %u",`
`599`	`599`	`XLogRecBlockImageApply(record,block_id) ?`
`600`	`600`	`"" :" for WAL verification",`
`601`	`601`	`record->blocks[block_id].hole_offset,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite4d9212

File tree

1 file changed

1 file changed

`‎src/bin/pg_waldump/pg_waldump.c`

0 commit comments