Commite4c61be

committed

Use fabsf() instead of Abs() or fabs() where appropriate

This function is new in C99.Reviewed-by: Zhang Mingli <zmlpostgres@gmail.com>Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://www.postgresql.org/message-id/flat/4beb42b5-216b-bce8-d452-d924d5794c63%40enterprisedb.com

1 parent2473cb9 commite4c61beCopy full SHA for e4c61be

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ float4_dist(PG_FUNCTION_ARGS)`
`102`	`102`	`if (unlikely(isinf(r))&& !isinf(a)&& !isinf(b))`
`103`	`103`	`float_overflow_error();`
`104`	`104`
`105`		`-PG_RETURN_FLOAT4(Abs(r));`
	`105`	`+PG_RETURN_FLOAT4(fabsf(r));`
`106`	`106`	`}`
`107`	`107`
`108`	`108`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ g_int_picksplit(PG_FUNCTION_ARGS)`
`540`	`540`	`union_d=inner_int_union(datum_r,datum_alpha);`
`541`	`541`	`rt__int_size(union_d,&size_beta);`
`542`	`542`	`pfree(union_d);`
`543`		`-costvector[i-1].cost=fabs((size_alpha-size_l)- (size_beta-size_r));`
	`543`	`+costvector[i-1].cost=fabsf((size_alpha-size_l)- (size_beta-size_r));`
`544`	`544`	`}`
`545`	`545`	`qsort((void*)costvector,maxoff,sizeof(SPLITCOST),comparecost);`
`546`	`546`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`#include"postgres.h"`
`11`	`11`
`12`	`12`	`#include<float.h>`
	`13`	`+#include<math.h>`
`13`	`14`
`14`	`15`	`#include"access/gist.h"`
`15`	`16`	`#include"access/stratnum.h"`
`@@ -706,15 +707,15 @@ rt_seg_size(SEG a, float size)`
`706`	`707`	`if (a== (SEG*)NULL\|\|a->upper <=a->lower)`
`707`	`708`	`*size=0.0;`
`708`	`709`	`else`
`709`		`-*size=(float)Abs(a->upper-a->lower);`
	`710`	`+*size=fabsf(a->upper-a->lower);`
`710`	`711`	`}`
`711`	`712`
`712`	`713`	`Datum`
`713`	`714`	`seg_size(PG_FUNCTION_ARGS)`
`714`	`715`	`{`
`715`	`716`	`SEG*seg=PG_GETARG_SEG_P(0);`
`716`	`717`
`717`		`-PG_RETURN_FLOAT4((float)Abs(seg->upper-seg->lower));`
	`718`	`+PG_RETURN_FLOAT4(fabsf(seg->upper-seg->lower));`
`718`	`719`	`}`
`719`	`720`
`720`	`721`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -593,7 +593,7 @@ float4abs(PG_FUNCTION_ARGS)`
`593`	`593`	`{`
`594`	`594`	`float4arg1=PG_GETARG_FLOAT4(0);`
`595`	`595`
`596`		`-PG_RETURN_FLOAT4((float4)fabs(arg1));`
	`596`	`+PG_RETURN_FLOAT4(fabsf(arg1));`
`597`	`597`	`}`
`598`	`598`
`599`	`599`	`/*`

Comments

(0)