Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commite4ba100

Browse files
committed
Refresh apply delay on reload of recovery_min_apply_delay at recovery
This commit ensures that the wait interval in the replay delay loopwaiting for an amount of time defined by recovery_min_apply_delay iscorrectly handled on reload, recalculating the delay if this GUC valueis updated, based on the timestamp of the commit record being replayed.The previous behavior would be problematic for example with replaystill waiting even if the delay got reduced or just cancelled. If theapply delay was increased to a larger value, the wait would have justrespected the old value set, finishing earlier.Author: Soumyadeep Chakraborty, Ashwin AgrawalReviewed-by: Kyotaro Horiguchi, Michael PaquierDiscussion:https://postgr.es/m/CAE-ML+93zfr-HLN8OuxF0BjpWJ17O5dv1eMvSE5jsj9jpnAXZA@mail.gmail.comBackpatch-through: 9.6
1 parent0a208ed commite4ba100

File tree

1 file changed

+11
-2
lines changed
  • src/backend/access/transam

1 file changed

+11
-2
lines changed

‎src/backend/access/transam/xlog.c

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6248,14 +6248,23 @@ recoveryApplyDelay(XLogReaderState *record)
62486248
{
62496249
ResetLatch(&XLogCtl->recoveryWakeupLatch);
62506250

6251-
/* might change the trigger file's location */
6251+
/*
6252+
* This might change recovery_min_apply_delay or the trigger file's
6253+
* location.
6254+
*/
62526255
HandleStartupProcInterrupts();
62536256

62546257
if (CheckForStandbyTrigger())
62556258
break;
62566259

62576260
/*
6258-
* Wait for difference between GetCurrentTimestamp() and delayUntil
6261+
* Recalculate delayUntil as recovery_min_apply_delay could have
6262+
* changed while waiting in this loop.
6263+
*/
6264+
delayUntil=TimestampTzPlusMilliseconds(xtime,recovery_min_apply_delay);
6265+
6266+
/*
6267+
* Wait for difference between GetCurrentTimestamp() and delayUntil.
62596268
*/
62606269
msecs=TimestampDifferenceMilliseconds(GetCurrentTimestamp(),
62616270
delayUntil);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp