NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite474dd1

committed

Bruce,

Attached is a small fix for a stupid mistake I made in comment.c- an attempt to drop a non-existent comment would dump core :-(.Sometimes, I'm as sharp as a marble.Sorry,Mike Mascari

1 parent8cfb8c6 commite474dd1Copy full SHA for e474dd1

File tree

1 file changed

-3

lines changed

src/backend/commands
- comment.c

1 file changed

-3

lines changed

`‎src/backend/commands/comment.c‎`

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -171,9 +171,15 @@ void CreateComments(Oid oid, char *comment) {`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`}else {`
`174`		`-desctuple=heap_formtuple(tupDesc,values,nulls);`
`175`		`-heap_insert(description,desctuple);`
`176`		`-modified= TRUE;`
	`174`	`+`
	`175`	`+/* Only if comment is non-blank do we form a new tuple */`
	`176`	`+`
	`177`	`+if ((comment!=NULL)&& (strlen(comment)>0)) {`
	`178`	`+desctuple=heap_formtuple(tupDesc,values,nulls);`
	`179`	`+heap_insert(description,desctuple);`
	`180`	`+modified= TRUE;`
	`181`	`+}`
	`182`	`+`
`177`	`183`	`}`
`178`	`184`
`179`	`185`	`/* Complete the scan, update indices, if necessary */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite474dd1

File tree

1 file changed

1 file changed

`‎src/backend/commands/comment.c‎`

0 commit comments