Commite46cd42

committed

Update reference to sampling algorithm in analyze.c

Commit83e176e moved row sampling functions from analyze.c toutils/misc/sampling.c, but failed to update comment referring tothe sampling algorithm from Jeff Vitter's paper. Correct thecomment by pointing to utils/misc/sampling.c.Author: Etsuro FujitaDiscussion:https://postgr.es/m/CAPmGK154gp%2BQd%3DcorQOv%2BPmbyVyZBjp_%2Bhb766UJeD1e_ie6XQ%40mail.gmail.com

1 parent05b2758 commite46cd42Copy full SHA for e46cd42

File tree

-7

lines changed

-7

lines changed

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -1252,13 +1252,13 @@ acquire_sample_rows(Relation onerel, int elevel,`
`1252`	`1252`	`* The first targrows sample rows are simply copied into the`
`1253`	`1253`	`* reservoir. Then we start replacing tuples in the sample`
`1254`	`1254`	`* until we reach the end of the relation. This algorithm is`
`1255`		`- * from Jeff Vitter's paper (see full citationbelow). It`
`1256`		`- * works by repeatedly computing the number of tuples to skip`
`1257`		`- *before selecting a tuple, which replaces a randomly chosen`
`1258`		`- *element of the reservoir (current set oftuples). At all`
`1259`		`- *times the reservoir is a true random sample ofthetuples`
`1260`		`- * we've passed over so far, so when we fall off the end of`
`1261`		`- * the relation we're done.`
	`1255`	`+ * from Jeff Vitter's paper (see full citationin`
	`1256`	`+ *utils/misc/sampling.c). Itworks by repeatedly computing`
	`1257`	`+ *the number of tuples to skip before selecting a tuple,`
	`1258`	`+ *which replaces a randomly chosen element ofthe reservoir`
	`1259`	`+ *(current set of tuples). At all timesthereservoir is a`
	`1260`	`+ *true random sample of the tupleswe've passed over so far,`
	`1261`	`+ *so when we fall off the end ofthe relation we're done.`
`1262`	`1262`	`*/`
`1263`	`1263`	`if (numrows<targrows)`
`1264`	`1264`	`rows[numrows++]=heap_copytuple(&targtuple);`

Comments

(0)