NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite42e2f3

committed

PL/Python: Fix potential NULL pointer dereference

Afterd0aa965, one error path inPLy_spi_execute_fetch_result() could result in the variable "result"being dereferenced after being set to NULL. To fix that, just clear theresources right there and return early.Also add another SPI_freetuptable() call so that that is cleared in allerror paths.discovered by John Naylor <jcnaylor@gmail.com> via scan-build

1 parent7b88d63 commite42e2f3Copy full SHA for e42e2f3

File tree

1 file changed

-1

lines changed

src/pl/plpython
- plpy_spi.c

1 file changed

-1

lines changed

`‎src/pl/plpython/plpy_spi.c`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,10 @@ PLy_spi_execute_fetch_result(SPITupleTable *tuptable, uint64 rows, int status)`
`361`	`361`
`362`	`362`	`result= (PLyResultObject*)PLy_result_new();`
`363`	`363`	`if (!result)`
	`364`	`+{`
	`365`	`+SPI_freetuptable(tuptable);`
`364`	`366`	`returnNULL;`
	`367`	`+}`
`365`	`368`	`Py_DECREF(result->status);`
`366`	`369`	`result->status=PyInt_FromLong(status);`
`367`	`370`
`@@ -414,7 +417,9 @@ PLy_spi_execute_fetch_result(SPITupleTable *tuptable, uint64 rows, int status)`
`414`	`417`	`if (!result->rows)`
`415`	`418`	`{`
`416`	`419`	`Py_DECREF(result);`
`417`		`-result=NULL;`
	`420`	`+MemoryContextDelete(cxt);`
	`421`	`+SPI_freetuptable(tuptable);`
	`422`	`+returnNULL;`
`418`	`423`	`}`
`419`	`424`	`else`
`420`	`425`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite42e2f3

File tree

1 file changed

1 file changed

`‎src/pl/plpython/plpy_spi.c`

0 commit comments