NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite42b3c3

committed

Fix GiST index deletion assert issue.

Avoid calling heap_index_delete_tuples() with an empty deltids array toavoid an assertion failure.This issue was arguably an oversight in commitb5f58cf, though thefailing assert itself was added by my recent commitd168b66. Nobackpatch, though, since the oversight is harmless in the back branches.Author: Peter Geoghegan <pg@bowt.ie>Reported-By: Jaime Casanova <jcasanov@systemguards.com.ec>Discussion:https://postgr.es/m/CAJKUy5jscES84n3puE=sYngyF+zpb4wv8UMtuLnLPv5z=6yyNw@mail.gmail.com

1 parent32bef75 commite42b3c3Copy full SHA for e42b3c3

File tree

2 files changed

-6

lines changed

src/backend/access
- gist
  - gist.c
- index
  - genam.c

2 files changed

-6

lines changed

`‎src/backend/access/gist/gist.c`

Lines changed: 7 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1645,7 +1645,6 @@ gistprunepage(Relation rel, Page page, Buffer buffer, Relation heapRel)`
`1645`	`1645`	`intndeletable=0;`
`1646`	`1646`	`OffsetNumberoffnum,`
`1647`	`1647`	`maxoff;`
`1648`		`-TransactionIdlatestRemovedXid=InvalidTransactionId;`
`1649`	`1648`
`1650`	`1649`	`Assert(GistPageIsLeaf(page));`
`1651`	`1650`
`@@ -1664,13 +1663,15 @@ gistprunepage(Relation rel, Page page, Buffer buffer, Relation heapRel)`
`1664`	`1663`	`deletable[ndeletable++]=offnum;`
`1665`	`1664`	`}`
`1666`	`1665`
`1667`		`-if (XLogStandbyInfoActive()&&RelationNeedsWAL(rel))`
`1668`		`-latestRemovedXid=`
`1669`		`-index_compute_xid_horizon_for_tuples(rel,heapRel,buffer,`
`1670`		`-deletable,ndeletable);`
`1671`		`-`
`1672`	`1666`	`if (ndeletable>0)`
`1673`	`1667`	`{`
	`1668`	`+TransactionIdlatestRemovedXid=InvalidTransactionId;`
	`1669`	`+`
	`1670`	`+if (XLogStandbyInfoActive()&&RelationNeedsWAL(rel))`
	`1671`	`+latestRemovedXid=`
	`1672`	`+index_compute_xid_horizon_for_tuples(rel,heapRel,buffer,`
	`1673`	`+deletable,ndeletable);`
	`1674`	`+`
`1674`	`1675`	`START_CRIT_SECTION();`
`1675`	`1676`
`1676`	`1677`	`PageIndexMultiDelete(page,deletable,ndeletable);`

`‎src/backend/access/index/genam.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -301,6 +301,8 @@ index_compute_xid_horizon_for_tuples(Relation irel,`
`301`	`301`	`Pageipage=BufferGetPage(ibuf);`
`302`	`302`	`IndexTupleitup;`
`303`	`303`
	`304`	`+Assert(nitems>0);`
	`305`	`+`
`304`	`306`	`delstate.bottomup= false;`
`305`	`307`	`delstate.bottomupfreespace=0;`
`306`	`308`	`delstate.ndeltids=0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite42b3c3

File tree

2 files changed

2 files changed

`‎src/backend/access/gist/gist.c`

`‎src/backend/access/index/genam.c`

0 commit comments