Commite3ff8c3

committed

pg_waldump: Fix small memory leak when rmgr->rm_identify returns NULL.

This got broken in604f795, shortly after rm_identify'sintroduction.Author: Andres FreundDiscussion:https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.deBackpatch: 9.5, where rm_identify was introduced

1 parent9bf2476 commite3ff8c3Copy full SHA for e3ff8c3

File tree

-5

lines changed

-5

lines changed

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -448,17 +448,18 @@ XLogDumpDisplayRecord(XLogDumpConfig config, XLogReaderState record)`
`448`	`448`
`449`	`449`	`XLogDumpRecordLen(record,&rec_len,&fpi_len);`
`450`	`450`
`451`		`-id=desc->rm_identify(info);`
`452`		`-if (id==NULL)`
`453`		`-id=psprintf("UNKNOWN (%x)",info& ~XLR_INFO_MASK);`
`454`		`-`
`455`	`451`	`printf("rmgr: %-11s len (rec/tot): %6u/%6u, tx: %10u, lsn: %X/%08X, prev %X/%08X, ",`
`456`	`452`	`desc->rm_name,`
`457`	`453`	`rec_len,XLogRecGetTotalLen(record),`
`458`	`454`	`XLogRecGetXid(record),`
`459`	`455`	`(uint32) (record->ReadRecPtr >>32), (uint32)record->ReadRecPtr,`
`460`	`456`	`(uint32) (xl_prev >>32), (uint32)xl_prev);`
`461`		`-printf("desc: %s ",id);`
	`457`	`+`
	`458`	`+id=desc->rm_identify(info);`
	`459`	`+if (id==NULL)`
	`460`	`+printf("desc: UNKNOWN (%x) ",info& ~XLR_INFO_MASK);`
	`461`	`+else`
	`462`	`+printf("desc: %s ",id);`
`462`	`463`
`463`	`464`	`/* the desc routine will printf the description directly to stdout */`
`464`	`465`	`desc->rm_desc(NULL,record);`

Comments

(0)