NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite37662f

committed

Minor improvements for waitlsn.c

* Remove extra includes * Fill 'cur' in addLSNWaiter() before taking the spinlock * Initialize 'endtime' with zero in WaitForLSN() to avoid compiler warningReported-by: Alvaro Herrera, Masahiko Sawada, Daniel GustafssonDiscussion:https://postgr.es/m/202404030658.hhj3vfxeyhft%40alvherre.pgsqlDiscussion:https://postgr.es/m/CAD21AoAx7irptnPH1OkkkNh9E0M6X-phfX7sYZfwoMsc1qV1sQ%40mail.gmail.com

1 parent9301308 commite37662fCopy full SHA for e37662f

File tree

1 file changed

-14

lines changed

src/backend/commands
- waitlsn.c

1 file changed

-14

lines changed

`‎src/backend/commands/waitlsn.c`

Lines changed: 4 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,28 +18,18 @@`
`18`	`18`	`#include<math.h>`
`19`	`19`
`20`	`20`	`#include"pgstat.h"`
`21`		`-#include"fmgr.h"`
`22`		`-#include"access/transam.h"`
`23`		`-#include"access/xact.h"`
`24`	`21`	`#include"access/xlog.h"`
`25`		`-#include"access/xlogdefs.h"`
`26`	`22`	`#include"access/xlogrecovery.h"`
`27`		`-#include"catalog/pg_type.h"`
`28`	`23`	`#include"commands/waitlsn.h"`
`29`		`-#include"executor/spi.h"`
`30`	`24`	`#include"funcapi.h"`
`31`	`25`	`#include"miscadmin.h"`
`32`		`-#include"storage/ipc.h"`
`33`	`26`	`#include"storage/latch.h"`
`34`		`-#include"storage/pmsignal.h"`
`35`	`27`	`#include"storage/proc.h"`
`36`	`28`	`#include"storage/shmem.h"`
`37`		`-#include"storage/sinvaladt.h"`
`38`		`-#include"utils/builtins.h"`
`39`	`29`	`#include"utils/pg_lsn.h"`
`40`	`30`	`#include"utils/snapmgr.h"`
`41`		`-#include"utils/timestamp.h"`
`42`	`31`	`#include"utils/fmgrprotos.h"`
	`32`	`+#include"utils/wait_event_types.h"`
`43`	`33`
`44`	`34`	`/* Add to / delete from shared memory array */`
`45`	`35`	`staticvoidaddLSNWaiter(XLogRecPtrlsn);`
`@@ -88,11 +78,11 @@ addLSNWaiter(XLogRecPtr lsn)`
`88`	`78`	`WaitLSNProcInfocur;`
`89`	`79`	`inti;`
`90`	`80`
`91`		`-SpinLockAcquire(&waitLSN->mutex);`
`92`		`-`
`93`	`81`	`cur.procnum=MyProcNumber;`
`94`	`82`	`cur.waitLSN=lsn;`
`95`	`83`
	`84`	`+SpinLockAcquire(&waitLSN->mutex);`
	`85`	`+`
`96`	`86`	`for (i=0;i<waitLSN->numWaitedProcs;i++)`
`97`	`87`	`{`
`98`	`88`	`if (waitLSN->procInfos[i].waitLSN >=cur.waitLSN)`
`@@ -226,7 +216,7 @@ void`
`226`	`216`	`WaitForLSN(XLogRecPtrtargetLSN,int64timeout)`
`227`	`217`	`{`
`228`	`218`	`XLogRecPtrcurrentLSN;`
`229`		`-TimestampTzendtime;`
	`219`	`+TimestampTzendtime=0;`
`230`	`220`
`231`	`221`	`/* Shouldn't be called when shmem isn't initialized */`
`232`	`222`	`Assert(waitLSN);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite37662f

File tree

1 file changed

1 file changed

`‎src/backend/commands/waitlsn.c`

0 commit comments