NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite3731ba

committed

Repair two portability oversights of new test

First, as pointed out by Tom Lane and Michael Paquier, I failed torealize that Windows' PostgresNode needs an extra pg_hba.conf line(added by PostgresNode->set_replication_conf, called internally by->init() when 'allows_streaming=>1' is given -- but I purposefullyomitted that). I think a good fix should be to have nodes with only'has_archiving=>1' set up for replication too, but that's a biggerdiscussion. Fix it by calling ->set_replication_conf, which is notunprecedented, as pointed out by Andrew Dunstan.I also forgot to uncomment a ->finish() call for a pumpable IPC::Runfile descriptor. Apparently this is innocuous in almost all platforms.Backpatch to 14. The older branches were added this file too, but notthis particular part of the test.Discussion:https://postgr.es/m/3000074.1632947632@sss.pgh.pa.usDiscussion:https://postgr.es/m/YVT7qwhR8JmC2kfz@paquier.xyz

1 parent64a8687 commite3731baCopy full SHA for e3731ba

File tree

1 file changed

-1

lines changed

src/test/recovery/t
- 026_overwrite_contrecord.pl

1 file changed

-1

lines changed

`‎src/test/recovery/t/026_overwrite_contrecord.pl`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,7 @@`
`101`	`101`	`$node->init(`
`102`	`102`	`has_archiving=> 1,`
`103`	`103`	`extra=> ['--wal-segsize=1']);`
	`104`	`+$node->set_replication_conf;`
`104`	`105`
`105`	`106`	`# Note: consistent use of forward slashes here avoids any escaping problems`
`106`	`107`	`# that arise from use of backslashes. That means we need to double-quote all`
`@@ -181,7 +182,7 @@`
`181`	`182`
`182`	`183`	`# Now crash the node with the transaction open`
`183`	`184`	`$node->stop('immediate');`
`184`		`-#$h->finish();`
	`185`	`+$h->finish();`
`185`	`186`	`$node->start;`
`186`	`187`	`$node->safe_psql('postgres','create table witness (a int);');`
`187`	`188`	`$node->safe_psql('postgres','insert into witness values (42)');`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite3731ba

File tree

1 file changed

1 file changed

`‎src/test/recovery/t/026_overwrite_contrecord.pl`

0 commit comments