NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite3679bc

committed

pg_resetwal: Corrections around -c option

The present pg_resetwal code hardcodes the minimum value for -c as 2,which is FrozenTransactionId, but it's not clear why that is allowed.After some research, it was probably a mistake in the original patch.Change it to FirstNormalTransactionId, which matches other xid-relatedoptions in pg_resetwal.Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>Discussion:https://www.postgresql.org/message-id/flat/d09f0e91-8757-642b-1a92-da9a52f5589a%40eisentraut.org

1 parent1d91d24 commite3679bcCopy full SHA for e3679bc

File tree

1 file changed

-6

lines changed

src/bin/pg_resetwal
- pg_resetwal.c

1 file changed

-6

lines changed

`‎src/bin/pg_resetwal/pg_resetwal.c`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -211,13 +211,13 @@ main(int argc, char *argv[])`
`211`	`211`	`exit(1);`
`212`	`212`	`}`
`213`	`213`
`214`		`-if (set_oldest_commit_ts_xid<2&&`
`215`		`-set_oldest_commit_ts_xid!=0)`
`216`		`-pg_fatal("transaction ID (-c) must be either0 or greater than or equal to2");`
	`214`	`+if (set_oldest_commit_ts_xid<FirstNormalTransactionId&&`
	`215`	`+set_oldest_commit_ts_xid!=InvalidTransactionId)`
	`216`	`+pg_fatal("transaction ID (-c) must be either%u or greater than or equal to%u",InvalidTransactionId,FirstNormalTransactionId);`
`217`	`217`
`218`		`-if (set_newest_commit_ts_xid<2&&`
`219`		`-set_newest_commit_ts_xid!=0)`
`220`		`-pg_fatal("transaction ID (-c) must be either0 or greater than or equal to2");`
	`218`	`+if (set_newest_commit_ts_xid<FirstNormalTransactionId&&`
	`219`	`+set_newest_commit_ts_xid!=InvalidTransactionId)`
	`220`	`+pg_fatal("transaction ID (-c) must be either%u or greater than or equal to%u",InvalidTransactionId,FirstNormalTransactionId);`
`221`	`221`	`break;`
`222`	`222`
`223`	`223`	`case'o':`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite3679bc

File tree

1 file changed

1 file changed

`‎src/bin/pg_resetwal/pg_resetwal.c`

0 commit comments