Commite33884d

committed

Free pre-modification HeapTuple in ALTER TABLE ... TYPE ...

This was an oversight in commit3b174b1.Per offline gripe from Alvaro HerreraBackpatch to release 11.

1 parent1db5667 commite33884dCopy full SHA for e33884d

File tree

-2

lines changed

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -9648,6 +9648,7 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,`
`9648`	`9648`	`DatumvaluesAtt[Natts_pg_attribute];`
`9649`	`9649`	`boolnullsAtt[Natts_pg_attribute];`
`9650`	`9650`	`boolreplacesAtt[Natts_pg_attribute];`
	`9651`	`+HeapTuplenewTup;`
`9651`	`9652`
`9652`	`9653`	`MemSet(valuesAtt,0,sizeof(valuesAtt));`
`9653`	`9654`	`MemSet(nullsAtt, false,sizeof(nullsAtt));`
`@@ -9673,8 +9674,10 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,`
`9673`	`9674`	`replacesAtt[Anum_pg_attribute_attmissingval-1]= true;`
`9674`	`9675`	`nullsAtt[Anum_pg_attribute_attmissingval-1]= false;`
`9675`	`9676`
`9676`		`-heapTup=heap_modify_tuple(heapTup,RelationGetDescr(attrelation),`
`9677`		`-valuesAtt,nullsAtt,replacesAtt);`
	`9677`	`+newTup=heap_modify_tuple(heapTup,RelationGetDescr(attrelation),`
	`9678`	`+valuesAtt,nullsAtt,replacesAtt);`
	`9679`	`+heap_freetuple(heapTup);`
	`9680`	`+heapTup=newTup;`
`9678`	`9681`	`attTup= (Form_pg_attribute)GETSTRUCT(heapTup);`
`9679`	`9682`	`}`
`9680`	`9683`	`}`

Comments

(0)