Commite2e3b8a

committed

Disable tests using injection points in installcheck

The 'gin' test injections faults to GIN index build. If another testrunning concurrently in the same cluster also tries to create a GINindex, it will hit the fault, too.To fix, disable tests using injection points when running against anexisting cluster. A better long-term solution would be to make theinjection points scoped to the database or process, but this will dofor now.Discussion:https://www.postgresql.org/message-id/CA%2BhUKGJYhcG_o2nwSK6r01eOZJwNWUJUbX%3D%3DAVnW84f-%2B8yamQ@mail.gmail.comDiscussion:https://www.postgresql.org/message-id/10fd6cdd-c5d9-46fe-9fa1-7e661191309e@iki.fi

1 parent071e3ad commite2e3b8aCopy full SHA for e2e3b8a

File tree

+10

-0

lines changed

+10

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,9 @@ EXTRA_INSTALL = src/test/modules/injection_points`
`4`	`4`
`5`	`5`	`REGRESS = gin_incomplete_splits`
`6`	`6`
	`7`	`+# The injection points are cluster-wide, so disable installcheck`
	`8`	`+NO_INSTALLCHECK = 1`
	`9`	`+`
`7`	`10`	`ifdefUSE_PGXS`
`8`	`11`	`PG_CONFIG = pg_config`
`9`	`12`	`PGXS :=$(shell$(PG_CONFIG) --pgxs)`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,5 +12,7 @@ tests += {`
`12`	`12`	`'sql': [`
`13`	`13`	`'gin_incomplete_splits',`
`14`	`14`	`],`
	`15`	`+# The injection points are cluster-wide, so disable installcheck`
	`16`	`+'runningcheck':false,`
`15`	`17`	`},`
`16`	`18`	`}`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,9 @@ PGFILEDESC = "injection_points - facility for injection points"`
`8`	`8`
`9`	`9`	`REGRESS = injection_points`
`10`	`10`
	`11`	`+# The injection points are cluster-wide, so disable installcheck`
	`12`	`+NO_INSTALLCHECK = 1`
	`13`	`+`
`11`	`14`	`ifdefUSE_PGXS`
`12`	`15`	`PG_CONFIG = pg_config`
`13`	`16`	`PGXS :=$(shell$(PG_CONFIG) --pgxs)`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,5 +33,7 @@ tests += {`
`33`	`33`	`'sql': [`
`34`	`34`	`'injection_points',`
`35`	`35`	`],`
	`36`	`+# The injection points are cluster-wide, so disable installcheck`
	`37`	`+'runningcheck':false,`
`36`	`38`	`},`
`37`	`39`	`}`

Comments

(0)