NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite2b37d9

committed

Use pg_pread() and pg_pwrite() in slru.c.

This avoids lseek() system calls at every SLRU I/O, as wasdone for relation files in commit c24dcd0c.Reviewed-by: Ashwin Agrawal <aagrawal@pivotal.io>Reviewed-by: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/CA%2BhUKG%2Biqke4uTRFj8D8uEUUgj%2BRokPSp%2BCWM6YYzaaamG9Wvg%40mail.gmail.comDiscussion:https://postgr.es/m/CA%2BhUKGJ%2BoHhnvqjn3%3DHro7xu-YDR8FPr0FL6LF35kHRX%3D_bUzg%40mail.gmail.com

1 parent022350b commite2b37d9Copy full SHA for e2b37d9

File tree

1 file changed

-21

lines changed

src/backend/access/transam
- slru.c

1 file changed

-21

lines changed

`‎src/backend/access/transam/slru.c`

Lines changed: 4 additions & 21 deletions

Original file line number	Diff line number	Diff line change
`@@ -669,7 +669,7 @@ SlruPhysicalReadPage(SlruCtl ctl, int pageno, int slotno)`
`669`	`669`	`SlruSharedshared=ctl->shared;`
`670`	`670`	`intsegno=pageno /SLRU_PAGES_PER_SEGMENT;`
`671`	`671`	`intrpageno=pageno %SLRU_PAGES_PER_SEGMENT;`
`672`		`-intoffset=rpageno*BLCKSZ;`
	`672`	`+off_toffset=rpageno*BLCKSZ;`
`673`	`673`	`charpath[MAXPGPATH];`
`674`	`674`	`intfd;`
`675`	`675`
`@@ -699,17 +699,9 @@ SlruPhysicalReadPage(SlruCtl ctl, int pageno, int slotno)`
`699`	`699`	`return true;`
`700`	`700`	`}`
`701`	`701`
`702`		`-if (lseek(fd, (off_t)offset,SEEK_SET)<0)`
`703`		`-{`
`704`		`-slru_errcause=SLRU_SEEK_FAILED;`
`705`		`-slru_errno=errno;`
`706`		`-CloseTransientFile(fd);`
`707`		`-return false;`
`708`		`-}`
`709`		`-`
`710`	`702`	`errno=0;`
`711`	`703`	`pgstat_report_wait_start(WAIT_EVENT_SLRU_READ);`
`712`		`-if (read(fd,shared->page_buffer[slotno],BLCKSZ)!=BLCKSZ)`
	`704`	`+if (pg_pread(fd,shared->page_buffer[slotno],BLCKSZ,offset)!=BLCKSZ)`
`713`	`705`	`{`
`714`	`706`	`pgstat_report_wait_end();`
`715`	`707`	`slru_errcause=SLRU_READ_FAILED;`
`@@ -749,7 +741,7 @@ SlruPhysicalWritePage(SlruCtl ctl, int pageno, int slotno, SlruFlush fdata)`
`749`	`741`	`SlruSharedshared=ctl->shared;`
`750`	`742`	`intsegno=pageno /SLRU_PAGES_PER_SEGMENT;`
`751`	`743`	`intrpageno=pageno %SLRU_PAGES_PER_SEGMENT;`
`752`		`-intoffset=rpageno*BLCKSZ;`
	`744`	`+off_toffset=rpageno*BLCKSZ;`
`753`	`745`	`charpath[MAXPGPATH];`
`754`	`746`	`intfd=-1;`
`755`	`747`
`@@ -862,18 +854,9 @@ SlruPhysicalWritePage(SlruCtl ctl, int pageno, int slotno, SlruFlush fdata)`
`862`	`854`	`}`
`863`	`855`	`}`
`864`	`856`
`865`		`-if (lseek(fd, (off_t)offset,SEEK_SET)<0)`
`866`		`-{`
`867`		`-slru_errcause=SLRU_SEEK_FAILED;`
`868`		`-slru_errno=errno;`
`869`		`-if (!fdata)`
`870`		`-CloseTransientFile(fd);`
`871`		`-return false;`
`872`		`-}`
`873`		`-`
`874`	`857`	`errno=0;`
`875`	`858`	`pgstat_report_wait_start(WAIT_EVENT_SLRU_WRITE);`
`876`		`-if (write(fd,shared->page_buffer[slotno],BLCKSZ)!=BLCKSZ)`
	`859`	`+if (pg_pwrite(fd,shared->page_buffer[slotno],BLCKSZ,offset)!=BLCKSZ)`
`877`	`860`	`{`
`878`	`861`	`pgstat_report_wait_end();`
`879`	`862`	`/* if write didn't set errno, assume problem is no disk space */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite2b37d9

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/slru.c`

0 commit comments