NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite29c565

committed

Remove dead code in formatting.c

Remove some code guarded by IS_MINUS() or IS_PLUS(), where the entirestanza is inside an else-block where both of these are false. Thisshould slightly improve test coverage.While at it, remove coding that apparently assumes that unsetting abit is so expensive that we have to first check if it's already setin the first place.Per Coverity report from Ranier VilelaAnalysis and review by Justin PryzbyDiscussion:https://www.postgresql.org/message-id/20221223010818.GP1153%40telsasoft.com

1 parentc981d91 commite29c565Copy full SHA for e29c565

File tree

1 file changed

-5

lines changed

src/backend/utils/adt
- formatting.c

1 file changed

-5

lines changed

`‎src/backend/utils/adt/formatting.c`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -5664,13 +5664,9 @@ NUM_processor(FormatNode node, NUMDesc Num, char *inout,`
`5664`	`5664`	`{`
`5665`	`5665`	`if (Np->sign!='-')`
`5666`	`5666`	`{`
`5667`		`-if (IS_BRACKET(Np->Num)&&IS_FILLMODE(Np->Num))`
	`5667`	`+if (IS_FILLMODE(Np->Num))`
`5668`	`5668`	`Np->Num->flag &= ~NUM_F_BRACKET;`
`5669`		`-if (IS_MINUS(Np->Num))`
`5670`		`-Np->Num->flag &= ~NUM_F_MINUS;`
`5671`	`5669`	`}`
`5672`		`-elseif (Np->sign!='+'&&IS_PLUS(Np->Num))`
`5673`		`-Np->Num->flag &= ~NUM_F_PLUS;`
`5674`	`5670`
`5675`	`5671`	`if (Np->sign=='+'&&IS_FILLMODE(Np->Num)&&IS_LSIGN(Np->Num)== false)`
`5676`	`5672`	`Np->sign_wrote= true;/* needn't sign */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite29c565

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/formatting.c`

0 commit comments