NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commite26d313

committed

Remove useless code

BuildDescForRelation() goes out of its way to fill in->constr->has_not_null, but that value is not used for anything later,so this code can all be removed. Note that BuildDescForRelation()doesn't make any effort to fill in the rest of ->constr, so there isno claim that that structure is completely filled in.Reviewed-by: Tomasz Rybak <tomasz.rybak@post.pl>Discussion:https://www.postgresql.org/message-id/flat/a368248e-69e4-40be-9c07-6c3b5880b0a6@eisentraut.org

1 parentda2aeba commite26d313Copy full SHA for e26d313

File tree

1 file changed

-22

lines changed

src/backend/commands
- tablecmds.c

1 file changed

-22

lines changed

`‎src/backend/commands/tablecmds.c`

Lines changed: 3 additions & 22 deletions

Original file line number	Diff line number	Diff line change
`@@ -1273,7 +1273,9 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,`
`1273`	`1273`	`*`
`1274`	`1274`	`* Given a list of ColumnDef nodes, build a TupleDesc.`
`1275`	`1275`	`*`
`1276`		`- * Note: tdtypeid will need to be filled in later on.`
	`1276`	`+ * Note: This is only for the limited purpose of table and view creation. Not`
	`1277`	`+ * everything is filled in. A real tuple descriptor should be obtained from`
	`1278`	`+ * the relcache.`
`1277`	`1279`	`*/`
`1278`	`1280`	`TupleDesc`
`1279`	`1281`	`BuildDescForRelation(const List *columns)`
`@@ -1282,7 +1284,6 @@ BuildDescForRelation(const List *columns)`
`1282`	`1284`	`AttrNumberattnum;`
`1283`	`1285`	`ListCell *l;`
`1284`	`1286`	`TupleDescdesc;`
`1285`		`-boolhas_not_null;`
`1286`	`1287`	`char *attname;`
`1287`	`1288`	`Oidatttypid;`
`1288`	`1289`	`int32atttypmod;`
`@@ -1294,7 +1295,6 @@ BuildDescForRelation(const List *columns)`
`1294`	`1295`	`*/`
`1295`	`1296`	`natts = list_length(columns);`
`1296`	`1297`	`desc = CreateTemplateTupleDesc(natts);`
`1297`		`-has_not_null = false;`
`1298`	`1298`
`1299`	`1299`	`attnum = 0;`
`1300`	`1300`
`@@ -1340,7 +1340,6 @@ BuildDescForRelation(const List *columns)`
`1340`	`1340`
`1341`	`1341`	`/* Fill in additional stuff not handled by TupleDescInitEntry */`
`1342`	`1342`	`att->attnotnull = entry->is_not_null;`
`1343`		`-has_not_null \|= entry->is_not_null;`
`1344`	`1343`	`att->attislocal = entry->is_local;`
`1345`	`1344`	`att->attinhcount = entry->inhcount;`
`1346`	`1345`	`att->attidentity = entry->identity;`
`@@ -1352,24 +1351,6 @@ BuildDescForRelation(const List *columns)`
`1352`	`1351`	`att->attstorage = GetAttributeStorage(att->atttypid, entry->storage_name);`
`1353`	`1352`	`}`
`1354`	`1353`
`1355`		`-if (has_not_null)`
`1356`		`-{`
`1357`		`-TupleConstr constr = (TupleConstr ) palloc0(sizeof(TupleConstr));`
`1358`		`-`
`1359`		`-constr->has_not_null = true;`
`1360`		`-constr->has_generated_stored = false;`
`1361`		`-constr->defval = NULL;`
`1362`		`-constr->missing = NULL;`
`1363`		`-constr->num_defval = 0;`
`1364`		`-constr->check = NULL;`
`1365`		`-constr->num_check = 0;`
`1366`		`-desc->constr = constr;`
`1367`		`-}`
`1368`		`-else`
`1369`		`-{`
`1370`		`-desc->constr = NULL;`
`1371`		`-}`
`1372`		`-`
`1373`	`1354`	`return desc;`
`1374`	`1355`	`}`
`1375`	`1356`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite26d313

File tree

1 file changed

1 file changed

`‎src/backend/commands/tablecmds.c`

0 commit comments